Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicode: update to version 15.0 #55079

Closed
golightlyb opened this issue Sep 14, 2022 · 14 comments
Closed

unicode: update to version 15.0 #55079

golightlyb opened this issue Sep 14, 2022 · 14 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.21

Comments

@golightlyb
Copy link
Contributor

This issue is intended as an umbrella tracking issue for Unicode 15 support.

Unicode 15 is now published.

Go currently supports Unicode 13 (#48621 was the issue for Unicode 14)

Additionally (#52485) CLDR support is also lagging.
@seankhliao
Copy link
Member

cc @robpike

@mvdan
Copy link
Member

mvdan commented Sep 14, 2022

Perhaps also cc @mpvl as he's still listed as a secondary owner in https://dev.golang.org/owners.

@robpike
Copy link
Contributor

robpike commented Sep 14, 2022

Yes, I have long forgotten the update sequence.

@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 19, 2022
@cherrymui cherrymui added this to the Go1.20 milestone Sep 19, 2022
CyrilBrulebois added a commit to CyrilBrulebois/go-textseg that referenced this issue Oct 7, 2022
@CyrilBrulebois
Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
53dcfee 
Issues upstream:
 - “unicode: update to version 14.0” (golang/go#48621)
 - “unicode: update to version 15.0” (golang/go#55079)

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
CyrilBrulebois added a commit to CyrilBrulebois/go-textseg that referenced this issue Oct 7, 2022
@CyrilBrulebois
Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
21a91c5 
Issues upstream:
 - unicode: update to version 14.0
    → golang/go#48621
 - unicode: update to version 15.0
    → golang/go#55079

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
CyrilBrulebois added a commit to CyrilBrulebois/go-textseg that referenced this issue Oct 7, 2022
@CyrilBrulebois
autoversion: Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
726865a 
Issues upstream:
 - unicode: update to version 14.0
    → golang/go#48621
 - unicode: update to version 15.0
    → golang/go#55079

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
@smasher164
Copy link
Member

There's a generator script in the x/text repo that has a doCore flag to update the core unicode package.
There's also a script inside x/text/unicode that only updates the rangetables.
It seems the top-level script calls all of the subpackage scripts.
Maybe after the rangetables are updated, one just copies them into the standard library?

@apparentlymart apparentlymart mentioned this issue Nov 16, 2022
Merged
@weebney weebney mentioned this issue Dec 12, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/456836 mentions this issue: all: upgrade Unicode from 13.0.0 to 15.0.0

@weebney weebney mentioned this issue Dec 12, 2022
Closed
@jpnjfk
Copy link

jpnjfk commented Jan 23, 2023

Is there a schedule for #52485 to use the newer CLDR for collation and formats?

@gopherbot gopherbot modified the milestones: Go1.20, Go1.21 Feb 1, 2023
johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 12, 2023
@weebney @johanbrandhorst
all: upgrade Unicode from 13.0.0 to 15.0.0
636dbd7 
Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates golang#48621
Fixes golang#55079

Change-Id: I40efd097eb746db0727ebf7437280916d1242e47
GitHub-Last-Rev: c8885ca
GitHub-Pull-Request: golang#57265
Reviewed-on: https://go-review.googlesource.com/c/go/+/456837
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Rob Pike <r@golang.org>
@dmitshur dmitshur mentioned this issue May 13, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/499618 mentions this issue: doc/go1.21: mention upgrade to Unicode 15.0.0

gopherbot pushed a commit that referenced this issue May 31, 2023
@ianlancetaylor @gopherbot
doc/go1.21: mention upgrade to Unicode 15.0.0
4406e8e 
For #48621
For #55079

Change-Id: I279b4fbf07d2fa9de9577559a4e17a57f5692aa3
Reviewed-on: https://go-review.googlesource.com/c/go/+/499618
Reviewed-by: Eli Bendersky <eliben@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Bypass: Ian Lance Taylor <iant@google.com>
@mknyszek mknyszek mentioned this issue Jun 1, 2023
Closed
@bcmills
Copy link
Contributor

bcmills commented Jun 12, 2023

It looks like the tables in x/net/idna and various parts of x/text have not been updated for Unicode 15.0, but were updated at the last Go unicode update (to 13.0). Does that need to happen before the 1.21 release?

(Reopening as a release-blocker until that question is resolved.)

@bcmills bcmills reopened this Jun 12, 2023
@bcmills bcmills added release-blocker NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 12, 2023
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jun 12, 2023
@prattmic
Copy link
Member

prattmic commented Jun 12, 2023 •
edited
Loading

For reference, these have pending CLs: https://go.dev/cl/501940 (x/net/idna) https://go.dev/cl/501936 (x/text).

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/503035 mentions this issue: all: prepare for Unicode 15.0.0

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/503036 mentions this issue: all: regenerate for Unicode 15.0.0

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/503055 mentions this issue: idna: update for Unicode 15.0.0

gopherbot pushed a commit to golang/text that referenced this issue Jun 13, 2023
@rsc @gopherbot
all: prepare for Unicode 15.0.0
e3c038a 
internal/gen has never been updated for Go 1.17's //go:build tags.
Do that, and add the entry for Unicode 15.0.0.

Unicode 15.0.0 will change 9fff to be a CJK ideograph, which will
break the unicode/runenames example test.
Delete that part of the example.

For golang/go#55079.

Change-Id: I12b0c6d031d6d6e1970c8fe6eb5453fa64c9f365
Reviewed-on: https://go-review.googlesource.com/c/text/+/503035
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
gopherbot pushed a commit to golang/text that referenced this issue Jun 13, 2023
@rsc @gopherbot
all: regenerate for Unicode 15.0.0
2df65d7 
go generate ./...

This CL only contains the changes made by go generate ./...

For golang/go#55079.

Change-Id: I840205f9046e6ccaab370b1dc5393aaf02d5fcb2
Reviewed-on: https://go-review.googlesource.com/c/text/+/503036
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Jun 13, 2023
@rsc @gopherbot
idna: update for Unicode 15.0.0
f5464dd 
Changes entirely automated, the result of running

	cd src/golang.org/x/text
	go generate ./...

(which also edits x/net for us).

For golang/go#55079.

Change-Id: I6a638949ff2c53bc98c635e5e3b5ed672b51d71a
Reviewed-on: https://go-review.googlesource.com/c/net/+/503055
Run-TryBot: Russ Cox <rsc@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/502878 mentions this issue: all: update vendored dependencies

gopherbot pushed a commit that referenced this issue Jun 13, 2023
@prattmic
all: update vendored dependencies
80629ca 
Generated with x/build/cmd/updatestd.

For #36905.
For #55079.

Change-Id: I5ba28993359cb5bbfb1bc7cfcea9576b07fcfb14
Reviewed-on: https://go-review.googlesource.com/c/go/+/502878
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 13, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/509099 mentions this issue: all: update vendored dependencies

gopherbot pushed a commit that referenced this issue Jul 12, 2023
@rsc
all: update vendored dependencies
6244b19 
Generated by:

	go install golang.org/x/tools/cmd/bundle@latest
	go install golang.org/x/build/cmd/updatestd@latest
	updatestd -goroot=$GOROOT -branch=master

For #36905.
For #55079.

Fixes #61174 (vet checkers understanding Go language version).
Fixes #61200 (slog InfoCtx -> InfoContext etc).

Change-Id: I4f2c86960ce72d6df06e23da1b1297ab3ff2eecf
Reviewed-on: https://go-review.googlesource.com/c/go/+/509099
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@rsc @bradfitz
all: update vendored dependencies
64f6af6 
Generated by:

	go install golang.org/x/tools/cmd/bundle@latest
	go install golang.org/x/build/cmd/updatestd@latest
	updatestd -goroot=$GOROOT -branch=master

For golang#36905.
For golang#55079.

Fixes golang#61174 (vet checkers understanding Go language version).
Fixes golang#61200 (slog InfoCtx -> InfoContext etc).

Change-Id: I4f2c86960ce72d6df06e23da1b1297ab3ff2eecf
Reviewed-on: https://go-review.googlesource.com/c/go/+/509099
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
apparentlymart pushed a commit to apparentlymart/go-textseg that referenced this issue Aug 29, 2023
@CyrilBrulebois @apparentlymart
autoversion: Mark Go 1.17, 1.18, and 1.19 as using Unicode 13.
45ed1d8 
Issues upstream:
 - unicode: update to version 14.0
    → golang/go#48621
 - unicode: update to version 15.0
    → golang/go#55079

At the moment, Unicode 15 is on the roadmap for Go 1.20, while Go 1.19
is confirmed to still be using Unicode 13 (e.g. on Debian unstable and
Debian testing).
awly pushed a commit to tailscale/go that referenced this issue Feb 7, 2024
@rsc @awly
all: update vendored dependencies
456388d 
Generated by:

	go install golang.org/x/tools/cmd/bundle@latest
	go install golang.org/x/build/cmd/updatestd@latest
	updatestd -goroot=$GOROOT -branch=master

For golang#36905.
For golang#55079.

Fixes golang#61174 (vet checkers understanding Go language version).
Fixes golang#61200 (slog InfoCtx -> InfoContext etc).

Change-Id: I4f2c86960ce72d6df06e23da1b1297ab3ff2eecf
Reviewed-on: https://go-review.googlesource.com/c/go/+/509099
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
@golang golang locked and limited conversation to collaborators Jul 11, 2024
veigaribo pushed a commit to veigaribo/template that referenced this issue Jul 29, 2024
@weebney @robpike
all: upgrade Unicode from 13.0.0 to 15.0.0
f2ac58c 
Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates golang/go#48621
Fixes golang/go#55079

Change-Id: I40efd097eb746db0727ebf7437280916d1242e47
GitHub-Last-Rev: c8885cab7a0c23632e1e5a433b1e8d5634a45a30
GitHub-Pull-Request: golang/go#57265
Reviewed-on: https://go-review.googlesource.com/c/go/+/456837
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Rob Pike <r@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.21
Development

Successfully merging a pull request may close this issue.

all: upgrade Unicode from 13.0.0 to 15.0.0
all: upgrade Unicode from 13.0.0 to 15.0.0