Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/bpf: failures about BPF packet outputs not matching #55235

Open
gopherbot opened this issue Sep 20, 2022 · 22 comments
Open

x/net/bpf: failures about BPF packet outputs not matching #55235

gopherbot opened this issue Sep 20, 2022 · 22 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Sep 20, 2022 •
edited by rsc
Loading 

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`

Bug automatically created to track these flakes.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 20, 2022
@gopherbot
Copy link
Contributor Author

gopherbot commented Sep 20, 2022 •
edited
Loading

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && test == "TestVMALUOpAdd"
2022-09-09 16:43 linux-s390x-ibm net@bea034e7 go@7c87012f golang.org/x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.28s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Sep 20, 2022
@rsc rsc moved this to Active in Test Flakes Sep 20, 2022
@gopherbot gopherbot changed the title x/net/bpf: flaky TestVMALUOpAdd x/net/bpf: TestVMALUOpAdd failures Sep 20, 2022
@rsc rsc changed the title x/net/bpf: TestVMALUOpAdd failures x/net/bpf: failures about BPF packet outputs not matching Sep 21, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2022-09-20 18:38 linux-s390x-ibm net@bf014ff8 go@bcd44b61 x/net/bpf.TestVMLoadConstantOK (log) 
--- FAIL: TestVMLoadConstantOK (0.12s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 1
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2022-10-04 15:45 linux-ppc64-buildlet net@8021a294 go@89566448 x/net/bpf.TestVMALUOpShiftLeft (log) 
--- FAIL: TestVMALUOpShiftLeft (0.08s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 1
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2022-10-14 08:14 linux-s390x-ibm net@f15817d1 go@89566448 x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.12s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2022-10-17 15:22 linux-s390x-ibm net@f25eb7ec go@947091d3 x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.41s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2022-10-20 15:09 linux-s390x-ibm net@da05058a go@4b5558ef x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.58s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2022-11-07 21:06 linux-mips-rtrk net@a2d827a3 go@ea4631cc x/net/bpf.TestVMJumpIfXGreaterThan (log) 
--- FAIL: TestVMJumpIfXGreaterThan (0.06s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 4
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-01-26 21:33 linux-s390x-ibm net@296f09aa go@dfd2ddd6 x/net/bpf.TestVMStoreScratchLoadScratchMultipleValues (log) 
--- FAIL: TestVMStoreScratchLoadScratchMultipleValues (0.07s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 2
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-04-07 18:10 linux-s390x-ibm net@3d5a8ee7 go@66cac9e1 x/net/bpf.TestVMALUOpOr (log) 
--- FAIL: TestVMALUOpOr (0.07s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 9
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-04-17 17:44 linux-s390x-ibm net@eb1572ce go@fd786a55 x/net/bpf.TestVMLoadMemShiftLoadIndirectOK (log) 
--- FAIL: TestVMLoadMemShiftLoadIndirectOK (0.08s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 28
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-04-17 17:44 linux-s390x-ibm net@eb1572ce go@130a7f8e x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.20s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-04-19 19:08 linux-s390x-ibm net@938ff153 go@e23322e2 x/net/bpf.TestVMALUOpMul (log) 
--- FAIL: TestVMALUOpMul (0.06s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 4
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-04-19 19:08 linux-s390x-ibm net@938ff153 go@715d53c0 x/net/bpf.TestVMJumpIfGreaterOrEqual (log) 
--- FAIL: TestVMJumpIfGreaterOrEqual (0.35s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 4
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-05-04 16:26 linux-s390x-ibm net@daac0cec go@8d5065ce x/net/bpf.TestVMALUOpXor (log) 
--- FAIL: TestVMALUOpXor (0.25s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 1
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-05-16 21:31 linux-s390x-ibm net@3b31286d go@099f5a98 x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.29s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented May 17, 2023

The vast majority of these failures are on linux/s390x. @golang/s390x, could you investigate?

@bcmills
Copy link
Contributor

bcmills commented May 17, 2023

(attn @danderson @mdlayher for x/net/bpf, per http://dev.golang.org/owners.)

@bcmills bcmills mentioned this issue May 19, 2023
Open
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-05-18 16:34 linux-s390x-ibm net@abee42a2 go@8f1031df x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.69s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-05-19 22:58 linux-s390x-ibm net@056145cf go@b950cc8f x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.15s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/bpf" && `Go BPF and OS BPF packet outputs do not match`
2023-06-01 14:35 linux-s390x-ibm net@10cf3880 go@38e2376f x/net/bpf.TestVMALUOpAdd (log) 
--- FAIL: TestVMALUOpAdd (0.24s)
    vm_bpf_test.go:122: output byte count does not match:
        - go: 3
        - os: 0
    vm_bpf_test.go:126: Go BPF and OS BPF packet outputs do not match

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/501155 mentions this issue: bpf: check for little endian CPU for OS VM comparison

gopherbot pushed a commit to golang/net that referenced this issue Jun 6, 2023
@mdlayher @gopherbot
bpf: check for little endian CPU for OS VM comparison
2796e09 
When I wrote these tests, I assumed the native endianness for the machine
was little endian. Explicitly check this so that the emulated BPF VM tests
can run on s390x, but we avoid test flakes related to endianness.

Updates golang/go#55235.

Change-Id: I9be430dfe7f97503af7a620ed80dcbacb66d73cc
Reviewed-on: https://go-review.googlesource.com/c/net/+/501155
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matt Layher <mdlayher@gmail.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/501615 mentions this issue: all: update x/sys to HEAD

gopherbot pushed a commit to golang/net that referenced this issue Jun 7, 2023
@gopherbot
all: update x/sys to HEAD
88a50b6 
An update is needed to pull in CL 494856, to allow the bpf test to
build on js and wasip1 after the test changes in CL 501155.

Updates golang/go#55235.
Updates golang/go#57237.

Change-Id: Iff48bad97453932065c27b0c8b4a3706ddcf659a
Reviewed-on: https://go-review.googlesource.com/c/net/+/501615
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Active
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot