-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/unix: possible missed change in generated file ztypes_solaris_amd64.go #55997
Comments
Experimentation suggests that the autogenerated change is incorrect. I think this is something we would fix in diff --git a/unix/mkpost.go b/unix/mkpost.go
index 76075c3..5337eca 100644
--- a/unix/mkpost.go
+++ b/unix/mkpost.go
@@ -96,6 +96,11 @@ func main() {
})
}
+ if goos == "solaris" {
+ iovecspec := regexp.MustCompile(`_Ctype_struct_iovec`)
+ b = iovecspec.ReplaceAll(b, []byte("Iovec"))
+ }
+
// Intentionally export __val fields in Fsid and Sigset_t
valRegex := regexp.MustCompile(`type (Fsid|Sigset_t) struct {(\s+)X__(bits|val)(\s+\S+\s+)}`)
b = valRegex.ReplaceAll(b, []byte("type $1 struct {${2}Val$4}")) |
Change-Id: Iaf1b90486c2b4c8227a81aa06abec8d26176566d
Fixes golang/go#55997 Change-Id: Iaf1b90486c2b4c8227a81aa06abec8d26176566d
I will open a CR with nshalman/sys@7bb33b5 |
Change https://go.dev/cl/437356 mentions this issue: |
/cc @ianlancetaylor |
I wonder whether instead of defining |
I defer to the expertise of others what the right solution to this is. I'd really love independent confirmation that this issue is real and not just something quirky on my system. If my solution is acceptable, the CR is there to be merged, but if a different approach is preferred, I'd love to let someone else fix it so that I can focus my limited spare time on the porting work that this interrupted. Thank you for your time and attention!! |
I think that @tklauser is right and that CL 412496 (which I wrote) was wrong. We should try to copy the existing int8 -> byte code in mkpost.go. |
I've abandoned https://go.dev/cl/437356 accordingly. |
Change https://go.dev/cl/484635 mentions this issue: |
Thank you, @tklauser! |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
As of commit f11e5e49a4ec85883999349b0dc6373df034397b I ran the following command in an unmodified checkout:
What did you expect to see?
No change to working tree.
What did you see instead?
I get the follow output from
git diff
:Is that a change that should be / have been applied to that file?
I was about to touch
types_solaris.go
for a different change and found this bit confusing.I think this is related to go #52885 / https://go-review.googlesource.com/c/sys/+/412496
The text was updated successfully, but these errors were encountered: