-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: improvements to package renaming #56184
Comments
Hmm. I think it should be fine to rename across modules as long as both modules are in the workspace..? |
I was looking forward to this feature! I tried package rename in the following environment and it seems that the renamed file is newly created and the original file is deleted. Visual Studio Code v1.72.2 |
@uh-zz yes, this is how VS Code handles the RenameFile operation. Unfortunately, I believe this is out of our control. |
Change https://go.dev/cl/450556 mentions this issue: |
Change https://go.dev/cl/450557 mentions this issue: |
…kage's path contains "internal" as a segment For golang/go#56184. Change-Id: Id33650adb5befb0a2cdead28425ad6ec8f7d9e0d Reviewed-on: https://go-review.googlesource.com/c/tools/+/450556 gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
I've updated the tasks here to separate the feature request of supporting arbitrary renaming of package paths into #57171. |
Change https://go.dev/cl/459416 mentions this issue: |
…enaming Check active go.mod files in the workspace to see if any replace directives need to be fixed if package renaming affects the replaced locations in any go.mod files. For golang/go#56184. Change-Id: I98ea07a602c39168d13f42f1b7a5f6738e194ece Reviewed-on: https://go-review.googlesource.com/c/tools/+/459416 Reviewed-by: Robert Findley <rfindley@google.com> Run-TryBot: Dylan Le <dungtuanle@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
@dle8 anything more to do here? |
No I think we can close this issue! |
This issue tracks improvements to package renaming that we are aiming to land in gopls@v0.11.0, namely:
The text was updated successfully, but these errors were encountered: