Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/exec: Plan 9 build has been broken by a Windows security fix (also breaks 1.19.3 and 1.18.8) [1.19 backport] #56551

Closed
gopherbot opened this issue Nov 3, 2022 · 2 comments
Closed

os/exec: Plan 9 build has been broken by a Windows security fix (also breaks 1.19.3 and 1.18.8) [1.19 backport] #56551

gopherbot opened this issue Nov 3, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.19.4

Comments

@gopherbot
Copy link
Contributor

@mdempsky requested issue #56544 to be considered for backport to the next 1.19 minor release.

@gopherbot Please backport to 1.18 and 1.19. The Windows security fix inadvertently broke Plan 9.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 3, 2022
@gopherbot gopherbot mentioned this issue Nov 3, 2022
Closed
@gopherbot gopherbot added this to the Go1.19.4 milestone Nov 3, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/447799 mentions this issue: [release-branch.go1.19] os/exec: allow NUL in environment variables on Plan 9

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Nov 9, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 9, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging a2335d0 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Nov 9, 2022
@mdempsky @mknyszek
[release-branch.go1.19] os/exec: allow NUL in environment variables o…
a2335d0 
…n Plan 9

Plan 9 uses NUL as os.PathListSeparator, so it's almost always going
to appear in the environment variable list. Exempt GOOS=plan9 from the
check for NUL in environment variables.

For #56284.
For #56544.
Fixes #56551.

Change-Id: I23df233cdf20c0a9a606fd9253e15a9b5482575a
Reviewed-on: https://go-review.googlesource.com/c/go/+/447715
Reviewed-by: David du Colombier <0intro@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/447799
Run-TryBot: David du Colombier <0intro@gmail.com>
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@mdempsky @andrew-d
[release-branch.go1.19] os/exec: allow NUL in environment variables o…
39fbccc 
…n Plan 9

Plan 9 uses NUL as os.PathListSeparator, so it's almost always going
to appear in the environment variable list. Exempt GOOS=plan9 from the
check for NUL in environment variables.

For golang#56284.
For golang#56544.
Fixes golang#56551.

Change-Id: I23df233cdf20c0a9a606fd9253e15a9b5482575a
Reviewed-on: https://go-review.googlesource.com/c/go/+/447715
Reviewed-by: David du Colombier <0intro@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/447799
Run-TryBot: David du Colombier <0intro@gmail.com>
@golang golang locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.19.4
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot