cmd/go/internal/modfetch/codehost: TestStat/gitrepo1 failures due to missing v1.2.3 tag
#56881
Assignees
Labels
FixPending
Issues that have a fix which has not yet been reviewed or submitted.
GoCommand
cmd/go
modules
NeedsFix
The path to resolution is known, but the work has not been done.
release-blocker
Milestone
Comments
gopherbot
added
the
NeedsInvestigation
|
Found new dashboard test flakes for: 2022-11-19 01:19 linux-amd64-longtest go@c6cdfd88 cmd/go/internal/modfetch/codehost.TestStat (log)2022-11-19 22:39 linux-amd64-longtest go@bda02354 cmd/go/internal/modfetch/codehost.TestStat (log) |
bcmills
changed the title
v1.2.3 tag
This was referenced Nov 21, 2022
bcmills
changed the title
v1.2.3 tagv1.2.3 tag
|
Found new dashboard test flakes for: 2023-01-09 18:21 linux-386-longtest go@8232a09e cmd/go/internal/modfetch/codehost.TestStat (log)2023-01-17 19:47 linux-386-longtest go@83f86889 cmd/go/internal/modfetch/codehost.TestStat (log)2023-02-22 14:55 linux-amd64-longtest-race go@4a1829b6 cmd/go/internal/modfetch/codehost.TestStat (log)2023-02-24 19:00 linux-arm64-longtest go@21ff6704 cmd/go/internal/modfetch/codehost.TestStat (log) |
|
I'm going to add a skip for this failure mode first thing tomorrow. It seems to have a delightfully high repro rate on the |
|
Change https://go.dev/cl/492975 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
May 5, 2023
…smatches For #56881. Change-Id: If9d8fa2942e4dd8da5e673631cdc277e0fe6c962 Reviewed-on: https://go-review.googlesource.com/c/go/+/492975 Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
|
Change https://go.dev/cl/547155 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Dec 6, 2023
…instead of after gitRepo.statLocal reports tag and version information. If we are statting a hash that corresponds to a tag, we need to add that tag before calling statLocal so that it can be included in that information. Fixes #53955. Updates #56881. Change-Id: I69a71428e6ed9096d4cb8ed1bb79531415ff06c1 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/547155 Auto-Submit: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org>
|
I think this may be a |
|
|
This does not appear to be caused by a race with another test: |
|
The failing builder has |
|
No luck in the release notes. Running |
|
Found new dashboard test flakes for: 2023-12-15 19:35 linux-riscv64-jsing go@b60bf8f8 cmd/go/internal/modfetch/codehost.TestStat (log) |
|
Found new dashboard test flakes for: 2023-12-18 23:35 darwin-amd64-11_0 go@5b84d500 cmd/go/internal/modfetch/codehost.TestStat (log) |
|
Found new dashboard test flakes for: 2024-01-08 18:26 darwin-amd64-11_0 go@75984918 cmd/go/internal/modfetch/codehost.TestStat (log) |
|
This reproduces on the |
|
Bisecting |
|
Bisected the fix to git/git@eb04975: That commit was first released in Git 2.29.0. |
bcmills
removed
the
FixPending
|
Git protocol version 2 was introduced in Git 2.18, but the last time we updated the minimum supported Git version (in #26746 (comment)) we decided on 2.17.6. I will try to find a workaround that fixes the test for Git 2.17.6. |
|
...aaand 2.17.6 in particular passes the test. 😵💫 Back to bisecting, I guess. 😩 |
(git/git@61c7711, released in Git 2.21) |
|
I checked by running Adding
|
bcmills
added
the
FixPending
|
Change https://go.dev/cl/556358 mentions this issue: |
bcmills
added
GoCommand
|
Marking as release-blocker because this is causing test flakes on the Go builders. Since the root cause is a |
|
The underlying |
ezz-no
pushed a commit
to ezz-no/go-ezzno
that referenced
this issue
Feb 18, 2024
…instead of after gitRepo.statLocal reports tag and version information. If we are statting a hash that corresponds to a tag, we need to add that tag before calling statLocal so that it can be included in that information. Fixes golang#53955. Updates golang#56881. Change-Id: I69a71428e6ed9096d4cb8ed1bb79531415ff06c1 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/547155 Auto-Submit: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org>
ezz-no
pushed a commit
to ezz-no/go-ezzno
that referenced
this issue
Feb 18, 2024
This works around a bug in 'git http-backend' that was fixed in Git 2.34.0,¹ and will hopefully allow the tests in cmd/go/internal/modfetch/codehost to pass reliably using older Git releases (I tested with 2.30.2). ¹git/git@ff6a37c Fixes golang#56881. Change-Id: Icd2e4d252d5f712685d146f34e11922dd0c41ff0 Reviewed-on: https://go-review.googlesource.com/c/go/+/549795 Reviewed-by: Michael Matloob <matloob@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Bryan Mills <bcmills@google.com>
ezz-no
pushed a commit
to ezz-no/go-ezzno
that referenced
this issue
Feb 18, 2024
In gitRepo.stat, we were checking ref != "" twice, which confused me during casual reading because it made it seem like the string could be empty when it actually never is. For golang#56881. Change-Id: Ib83303a149ea771399cb55fedd5dfa02ad411ff0 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/549855 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Michael Matloob <matloob@golang.org>
ezz-no
pushed a commit
to ezz-no/go-ezzno
that referenced
this issue
Feb 18, 2024
This works around an apparent bug in the Git HTTP backend, introduced in Git 2.21, that causes responses for the version 1 protocol to provide incomplete tags. For Git commands older than 2.18, this configuration flag is ignored. (Note that Git 2.29 and above already use protocol version 2 by default.) Fixes golang#56881. Change-Id: I9b241cfb604e5f633ca6a5d799df6706246684a7 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/556358 Run-TryBot: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>
|
Change https://go.dev/cl/585815 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
May 16, 2024
…t tags before statLocal instead of after gitRepo.statLocal reports tag and version information. If we are statting a hash that corresponds to a tag, we need to add that tag before calling statLocal so that it can be included in that information. For #53955. For #56881. For #64586 Change-Id: I69a71428e6ed9096d4cb8ed1bb79531415ff06c1 Reviewed-on: https://go-review.googlesource.com/c/go/+/547155 Auto-Submit: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org> (cherry picked from commit 7b5a373) Reviewed-on: https://go-review.googlesource.com/c/go/+/585815 Reviewed-by: Sam Thanawalla <samthanawalla@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: