Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/internal: module asm appears multiple times in workspace #57769

Closed
prattmic opened this issue Jan 12, 2023 · 2 comments
Closed

crypto/internal: module asm appears multiple times in workspace #57769

prattmic opened this issue Jan 12, 2023 · 2 comments
Assignees
@prattmic
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@prattmic
Copy link
Member

Running go work init && go work use -r . in the Go repo results in an unusable workspace:

$ go build std
go: module asm appears multiple times in workspace

src/crypto/internal/bigmod/_asm and src/crypto/internal/edwards25519/field/_asm are the two modules named asm. These should probably have unique names to avoid breaking builds.

cc @FiloSottile

Context: I don't actually particularly want to use a workspace of all modules in the go repo. I am generating cross-references for https://cs.opensource.google/go, and I want nested modules (like golang.org/x/tools/gopls) included. go work use -r . is a simple way to achieve that, and it seems silly to need a special case for the go repo when we could make this just work.
@prattmic prattmic added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 12, 2023
@prattmic prattmic added this to the Go1.21 milestone Jan 12, 2023
@prattmic prattmic self-assigned this Jan 12, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/461896 mentions this issue: all: give nested modules fully-qualified names

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/461942 mentions this issue: go/expect: remove invalid characters from test module path

johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 12, 2023
@prattmic @johanbrandhorst
all: give nested modules fully-qualified names
7242c43 
The two crypto modules are both named "asm". If both are included in a
single go.work (e.g., from `go work use -r .` in the repo), builds break
from "module asm appears multiple times in workspace".

Give these modules fully-qualified names to avoid conflicts. While we
are here, also expand the name of two other testdata modules. Those
modules don't currently conflict, but they have vague names at risk of
future conflicts.

Fixes golang#57769.

Change-Id: I2bd8a505051e92348d49560ec698ed921f2c81be
Reviewed-on: https://go-review.googlesource.com/c/go/+/461896
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
FiloSottile pushed a commit to FiloSottile/edwards25519 that referenced this issue Dec 10, 2023
@prattmic @FiloSottile
all: give nested modules fully-qualified names
5caf132 
The two crypto modules are both named "asm". If both are included in a
single go.work (e.g., from `go work use -r .` in the repo), builds break
from "module asm appears multiple times in workspace".

Give these modules fully-qualified names to avoid conflicts. While we
are here, also expand the name of two other testdata modules. Those
modules don't currently conflict, but they have vague names at risk of
future conflicts.

Fixes golang/go#57769.

Change-Id: I2bd8a505051e92348d49560ec698ed921f2c81be
Reviewed-on: https://go-review.googlesource.com/c/go/+/461896
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
@golang golang locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@prattmic prattmic

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@prattmic @gopherbot