x/tools/gopls/internal/lsp/protocol: CodeAction.Edit is always serialized #58687
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
protocol.CodeAction
can't be used to lazily compute workspace edits withcodeAction/resolve
asprotocol.CodeAction.Edit
is a struct value, and not a pointer to a struct, and is thus always serialized even when a zero value:I see in serialized output:
omitempty
is not applied byjson.Marshal
for zero-value structs (see #11939):I think the solution is for
{"CodeAction", "edit"}
to be marked aswantOptStar
:cc: @hyangah
The text was updated successfully, but these errors were encountered: