-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: crash with invalid metadata containing blank package name #60952
Comments
Thank you for the report. Is this an open-source repository? |
Yes, this is https://github.com/OffchainLabs/nitro |
Not reproducing immediately for me. Does this reproduce every time for you? Which file are you opening to get this failure? |
Yes every time, |
Thanks. I don't see that file in the master branch. Are you on a different branch? |
Sorry, I'm having a tough time getting a valid go build in that project. In the meantime, could you run this command and let me know if it outputs anything?
|
Hrm, I do have a valid Go build now, and yet still don't reproduce. Could you also share your settings.json? |
I can reproduce the issue locally, just from cloning the repo and running util/headerreader/header_reader.go:21:2: github.com/VictoriaMetrics/fastcache@v1.6.0 (replaced by ./fastcache): reading fastcache/go.mod: open /Users/adonovan/w/nitro/fastcache/go.mod: no such file or directory More generally,
|
Aha! Now I can reproduce as well. We're working on a fix. |
Change https://go.dev/cl/505219 mentions this issue: |
Change https://go.dev/cl/505222 mentions this issue: |
The importer assumes that packages have non-empty package path and name. Enforce this invariant when loading metadata. Fixes golang/go#60952 Change-Id: I2f4f18e475ba306d93c8b649d19897a584e5ba19 Reviewed-on: https://go-review.googlesource.com/c/tools/+/505219 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> (cherry picked from commit c8278fe) Reviewed-on: https://go-review.googlesource.com/c/tools/+/505222
0.12.4 This is a follow up to gopls@v0.12.3 fixing a crash in the new analysis driver, in the presence of certain invalid packages (golang/go#60952). 0.12.3 This release fixes a couple rare but significant performance regressions introduced in the v0.12.0 release.
gopls version: v0.12.3 (go1.20.2)
gopls flags:
update flags: proxy
extension version: 0.39.0
go version: 1.20.2
environment: Visual Studio Code darwin
initialization error: undefined
issue timestamp: Thu, 22 Jun 2023 16:03:59 GMT
restart history:
Thu, 22 Jun 2023 16:03:41 GMT: activation (enabled: true)
ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.
Hi, I just opened VSCODE after update and gopls now crashing. I'm running MacBook m2, Ventura 13.1
The text was updated successfully, but these errors were encountered: