cmd/go: go test and go generate add the wrong go to $PATH when the go command is run from the cross-compiled bin subdirectory
#64963
Milestone
Comments
bcmills
added
NeedsFix
|
Change https://go.dev/cl/560782 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Feb 5, 2024
In CL 356611 I changed cmd/go to run most of its tests (instead of skipping them all) when cross-compiled, such as with GOARCH=386 on an amd64 host. Unfortunately, since we don't have a CI builder that runs long tests in a cross-compiled configuration, some of the tests have rotted since then. This fixes 'GOARCH=386 go test cmd/go' on my workstation. For #64963. Updates #53936. Change-Id: If7f4bc8e8d1ace7d36010d7a1b652fc7b2ceb276 Cq-Include-Trybots: luci.golang.try:gotip-linux-386-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/560782 Auto-Submit: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org>
ezz-no
pushed a commit
to ezz-no/go-ezzno
that referenced
this issue
Feb 18, 2024
In CL 356611 I changed cmd/go to run most of its tests (instead of skipping them all) when cross-compiled, such as with GOARCH=386 on an amd64 host. Unfortunately, since we don't have a CI builder that runs long tests in a cross-compiled configuration, some of the tests have rotted since then. This fixes 'GOARCH=386 go test cmd/go' on my workstation. For golang#64963. Updates golang#53936. Change-Id: If7f4bc8e8d1ace7d36010d7a1b652fc7b2ceb276 Cq-Include-Trybots: luci.golang.try:gotip-linux-386-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/560782 Auto-Submit: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Go version
dfb2e42
What operating system and processor architecture are you using (
go env)?What did you do?
In a discussion with @matloob about #62114, I remembered the
$PATHenvironment logic that I added togo testandgo generatefor #51473 (comment).What did you expect to see?
If the
gocommand is being run from$GOROOT/bin/$GOOS_$GOARCH, as may be the case in multi-arch Go installations, the$PATHsetting used forgo generateandgo testshould include that path.Compare:
gocommand is run from the cross-compiledbinsubdirectory #62119What did you see instead?
The
$PATHsetting includes only$GOROOT/bin:https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/base/env.go;l=41-45;drc=dfb2e4265bf7654001c77925dfbbb9c38c0d1a95
And the path used for looking up the current
gocommand also checks only$GOROOT/bin:https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/generate/generate.go;l=490;drc=dfb2e4265bf7654001c77925dfbbb9c38c0d1a95
The text was updated successfully, but these errors were encountered: