Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: mod tidy reports toolchain not available with 'go 1.21' [1.21 backport] #67235

Closed
gopherbot opened this issue May 7, 2024 · 2 comments
Closed

cmd/go: mod tidy reports toolchain not available with 'go 1.21' [1.21 backport] #67235

gopherbot opened this issue May 7, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.21.11

Comments

@gopherbot
Copy link
Contributor

@matloob requested issue #62278 to be considered for backport to the next 1.21 minor release.

@gopherbot please backport to 1.21 and 1.22
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels May 7, 2024
@gopherbot gopherbot mentioned this issue May 7, 2024
Closed
@gopherbot gopherbot added this to the Go1.21.11 milestone May 7, 2024
@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 7, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/583797 mentions this issue: [release-branch.go1.21] cmd/go: download 1.X.0 instead of 1.X during toolchain upgrade.

@mx-psi mx-psi mentioned this issue May 10, 2024
Merged
gopherbot pushed a commit that referenced this issue May 10, 2024
@samthanawalla @cherrymui
[release-branch.go1.21] cmd/go: download 1.X.0 instead of 1.X during …
77cfa29 
…toolchain upgrade.

This CL modifies the download behavior when downloading a toolchain for 1.21+. Previously, Go would attempt to download 1.X when upgrading the toolchain which would cause the download to fail for 1.21+ since 1.X is an invalid toolchain. We will attempt to download 1.X.0 since that's likely what the user intended.

Additionally, we will also now provide a better error message when the
user provides a language version instead of a toolchain version for
1.21+.

For #66175
For #62278

Fixes #67235

Change-Id: I28f894290a19d8e3cd220e9d70aeca8f4447e5a1
Reviewed-on: https://go-review.googlesource.com/c/go/+/580217
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 27ed85d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/583797
@gopherbot
Copy link
Contributor Author

Closed by merging 77cfa29 to release-branch.go1.21.

This was referenced Jun 18, 2024
Closed
Closed
Closed
@toshipp toshipp mentioned this issue Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.21.11
Development

No branches or pull requests
2 participants
@gopherbot @matloob