-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go,x/mod/module: add COM0, LPT0 exclusion for allowed file names #67238
Comments
Change https://go.dev/cl/583836 mentions this issue: |
They have been added to the list of file names that are disallowed on Windows that's referenced in the comment to badWindowsNames, so add them to badWindowsNames. For golang/go#67238 For golang/go#66625 Change-Id: I82e5d70f33330f746783fd22090a3ebaf9408dfc Reviewed-on: https://go-review.googlesource.com/c/mod/+/583836 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
Change https://go.dev/cl/584335 mentions this issue: |
Please look at #67245 . It is debatable if these two file names are really reserved or not on Windows. |
To pull in CL 583836 Commands run go get golang.org/x/mod@6686f416970d4b8e2f54f521955dee89e6763c4b go mod tidy go mod vendor For #67238 For #66625 Change-Id: I77e49706481e068d27072a38d0d2464aa40d2dd0 Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-longtest,gotip-linux-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/584335 Reviewed-by: Sam Thanawalla <samthanawalla@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Oh interesting. Let's wait to get more information about whether they're reserved. |
I'm reverting the change. Closing this for now. We'll open a new issue if conclusive evidence is provided that those files are indeed not allowed on windows. |
We need to add COM0 and LPT0 to badWindowsNames in x/mod/module/module.go, but we should also do an analysis to make sure no one's affected, or to send PRs to affected modules to rename files whose name before the extension is COM0 or LPT0.
Steps:
The text was updated successfully, but these errors were encountered: