Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: clean cache with -n should only print remove commands. #27470

Closed
wants to merge 2 commits into from
Closed

clean: clean cache with -n should only print remove commands. #27470

wants to merge 2 commits into from

Conversation

xiaoxubeii
Copy link
Contributor

runClean when cleanCache should not execute remove commands when cfg.BuildN = true, but only print them.
Fixes #27469.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 3, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 5150:

Patch Set 1: Code-Review-1

Please add a test.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133055.
After addressing review feedback, remember to publish your drafts!

@xiaoxubeii
clean: clean cache with -n should only print remove commands.
97f7964 
runClean when cleanCache should not execute remove commands when cfg.BuildN = true, but only print them.
Fixes golang#27469.
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133055.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133055.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133055.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 29030:

Patch Set 5:

Patch Set 1: Code-Review-1

Please add a test.

Done

Please don’t reply on this GitHub thread. Visit golang.org/cl/133055.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur mentioned this pull request Sep 7, 2018
Closed
@gopherbot
Copy link
Contributor

Message from Gerrit User 5150:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/133055.
After addressing review feedback, remember to publish your drafts!

@xiaoxubeii xiaoxubeii closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxubeii @gopherbot @googlebot