Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/url: add URL.Masked() #34686

Closed
wants to merge 1 commit into from

Conversation

nrxr
Copy link

@nrxr nrxr commented Oct 4, 2019

Add method to mask the password in an URL, it's a derived method from
String() that's safe to be shown in logs.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Oct 4, 2019
Add method to mask the password in an URL, it's a derived method from
String() that's safe to be shown in logs.
@nrxr nrxr force-pushed the feat/net/url-add-mask-to-URL branch from c4d5a9d to 433ea7c Compare October 4, 2019 01:05
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Oct 4, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 433ea7c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/198799 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/198799.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matt Layher:

Patch Set 1: Code-Review-1

Sorry, I don't think this is a necessary addition to the standard library. Why not add this helper where you need it?

A proposal issue is the proper place to discuss this idea, rather than submitting a change.


Please don’t reply on this GitHub thread. Visit golang.org/cl/198799.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from nrxr:

Patch Set 1:

Patch Set 1: Code-Review-1

Sorry, I don't think this is a necessary addition to the standard library. Why not add this helper where you need it?

A proposal issue is the proper place to discuss this idea, rather than submitting a change.

Hi Matt,

Indeed, I already have it as a helper for myself (see: https://github.com/nrxr/maskpass). My proposal for addition comes as I was listening today to the Go Time podcast about security (see: https://pca.st/nzc8wpta) and I saw more people could be using it as it's very common to output URLs to logs.

It was my thinking at the moment of writing the patch set that maybe having a log-friendly mode in the standard library for something as regularly used as URLs would be really helpful instead of leaving it to helpers.

I understand if it's deemed unnecessary, my intention was to propose a sensible default for something that may create security issues for a regular developer.

Let me know if the consensus is that I should be submitting this as a proposal issue instead and I'll do just that.


Please don’t reply on this GitHub thread. Visit golang.org/cl/198799.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants