-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flag: exit 0 when -h or -help invoked but undefined #37530
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 40e6a97) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/221427 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Ian Lance Taylor: Patch Set 1: Code-Review-2 This kind of API change should normally go through the proposal process before sending a CL. See https://golang.org/s/proposal. Marking -2 temporarily since this change has not been approved. Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Shangjian Ding: Patch Set 2:
Hi Ian, it appears that the proposal was accepted earlier today @ #37533 . So I'm curious if we could move forward on this CL. Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Ian Lance Taylor: Patch Set 2: -Code-Review (4 comments) This change should have a test. Please also add an entry to doc/go1.15.html, following the pattern of the existing entries. Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
This PR (HEAD: 6f44a91) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/221427 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 40c9c36) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/221427 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: f8bf5ed) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/221427 to see it. Tip: You can toggle comments from me using the |
Message from Shangjian Ding: Patch Set 6:
Thanks for the review. I've added a test, updated the html doc, and pushed updates to address the 4 comments. Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Ian Lance Taylor: Patch Set 6: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
This PR (HEAD: 5165931) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/221427 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: c431241) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/221427 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 8: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Gobot Gobot: Patch Set 8: TryBots beginning. Status page: https://farmer.golang.org/try?commit=94055ae3 Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Gobot Gobot: Patch Set 8: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Gobot Gobot: Patch Set 8: TryBot-Result-1 1 of 20 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Ian Lance Taylor: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
This PR (HEAD: 83f64d7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/221427 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 9: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Gobot Gobot: Patch Set 9: TryBots beginning. Status page: https://farmer.golang.org/try?commit=f1a5eeec Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
Message from Gobot Gobot: Patch Set 9: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
flag treats -h or -help as a special case to print a nice help message, but exit with a status code of 2. This update makes that status code 0. Fixes #37533 Change-Id: I7e0bd29944ce46607fb7cfc6740734f7444a151a GitHub-Last-Rev: 83f64d7 GitHub-Pull-Request: #37530 Reviewed-on: https://go-review.googlesource.com/c/go/+/221427 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Message from Ian Lance Taylor: Patch Set 9: Code-Review+2 Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/221427. |
This PR is being closed because golang.org/cl/221427 has been merged. |
flag treats -h or -help as a special case to print a nice help message, but exit with a status code of 2. This update makes that status code 0. Fixes #37533 Change-Id: I7e0bd29944ce46607fb7cfc6740734f7444a151a GitHub-Last-Rev: 83f64d757bc3a9957c49caa5de74d05a96724771 GitHub-Pull-Request: golang/go#37530 Reviewed-on: https://go-review.googlesource.com/c/go/+/221427 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
flag treats -h or -help as a special case to print a nice help message, but exit with a status code of 2. This update makes that status code 0. Fixes #37533 Change-Id: I7e0bd29944ce46607fb7cfc6740734f7444a151a GitHub-Last-Rev: 83f64d757bc3a9957c49caa5de74d05a96724771 GitHub-Pull-Request: golang/go#37530 Reviewed-on: https://go-review.googlesource.com/c/go/+/221427 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
flag treats -h or -help as a special case to print a nice help message, but exit with a status code of 2. This update makes that status code 0. Fixes #37533 Change-Id: I7e0bd29944ce46607fb7cfc6740734f7444a151a GitHub-Last-Rev: 83f64d757bc3a9957c49caa5de74d05a96724771 GitHub-Pull-Request: golang/go#37530 Reviewed-on: https://go-review.googlesource.com/c/go/+/221427 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
flag treats -h or -help as a special case to print a nice help message, but exit with a status code of 2. This update makes that status code 0. Fixes #37533 Change-Id: I7e0bd29944ce46607fb7cfc6740734f7444a151a GitHub-Last-Rev: 83f64d757bc3a9957c49caa5de74d05a96724771 GitHub-Pull-Request: golang/go#37530 Reviewed-on: https://go-review.googlesource.com/c/go/+/221427 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
flag treats -h or -help as a special case to print a nice help
message, but exit with a status code of 2. This update makes
that status code 0.
Fixes #37533