net/http: allow sending 1xx responses #42597

dunglas · 2020-11-13T18:57:32Z

Currently, it's not possible to send informational responses such as
103 Early Hints or 102 Processing.

This patch allows calling WriteHeader() multiple times in order
to send informational responses before the final one.

If the status code is in the 1xx range, the current content of the header map
is also sent. Its content is not removed after the call to WriteHeader()
because the headers must also be included in the final response.

The Chrome and Fastly teams are starting a large-scale experiment to measure
the real-life impact of the 103 status code.
Using Early Hints is proposed as a (partial) alternative to Server Push,
which are going to be removed from Chrome:
https://groups.google.com/a/chromium.org/g/blink-dev/c/K3rYLvmQUBY/m/21anpFhxAQAJ

Being able to send this status code from servers implemented using Go would
help to see if implementing it in browsers is worth it.

Fixes #26089
Fixes #36734
Updates #26088

gopherbot · 2020-11-13T19:00:52Z

This PR (HEAD: 33505cb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-14T03:38:37Z

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-14T10:46:01Z

This PR (HEAD: 86d5d3e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-14T10:48:03Z

This PR (HEAD: c33edb7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-14T16:34:52Z

This PR (HEAD: 8979778) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-14T16:36:48Z

Message from Kévin Dunglas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-01T19:45:06Z

Message from Brad Fitzpatrick:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-02-10T13:27:06Z

This PR (HEAD: 491d2db) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Currently, it's not possible to send informational responses such as 103 Early Hints or 102 Processing. This patch allows calling WriteHeader() multiple times in order to send informational responses before the final one. It follows the patch for HTTP/1 (golang/go#42597) and HTTP/2 (golang/net#96). In conformance with RFC 8297, if the status code is 103 the current content of the header map is also sent. Its content is not removed after the call to WriteHeader() because the headers must also be included in the final response. The Chrome and Fastly teams are starting a large-scale experiment to measure the real-life impact of the 103 status code. Using Early Hints is proposed as a (partial) alternative to Server Push, which are going to be removed from Chrome: https://groups.google.com/a/chromium.org/g/blink-dev/c/K3rYLvmQUBY/m/21anpFhxAQAJ Being able to send this status code from servers implemented using Go would help to see if implementing it in browsers is worth it.

gopherbot · 2021-03-05T10:03:23Z

This PR (HEAD: 81c6f3f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

dunglas · 2021-03-05T11:11:15Z

Hi @bradfitz,

Is the tree open again? I improved the PR to flush headers as soon as possible and improved the documentation.
Also, a similar PR adding support for the 103 status code to the HTTP/3 implementation has been merged: quic-go/quic-go#3047

Cheers,

gopherbot · 2021-05-25T21:05:25Z

This PR (HEAD: 57a11d5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-16T08:56:50Z

This PR (HEAD: f32be5c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

dunglas · 2021-07-16T08:59:38Z

Hi @bradfitz,

I replied to all your comments and rebased. Is there anything else I can do to get this patch merged?

Thanks!

gopherbot · 2021-11-08T12:37:50Z

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T12:37:51Z

Message from Kévin Dunglas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-17T16:00:42Z

Message from Gopher Robot:

Patch Set 27: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-17T16:00:43Z

Message from Damien Neil:

Patch Set 27:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-05-17T16:05:23Z

This PR (HEAD: 06d749d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/269997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-05-17T16:09:39Z

Message from Kévin Dunglas:

Patch Set 29:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/269997.
After addressing review feedback, remember to publish your drafts!

Currently, it's not possible to send informational responses such as 103 Early Hints or 102 Processing. This patch allows calling WriteHeader() multiple times in order to send informational responses before the final one. If the status code is in the 1xx range, the current content of the header map is also sent. Its content is not removed after the call to WriteHeader() because the headers must also be included in the final response. The Chrome and Fastly teams are starting a large-scale experiment to measure the real-life impact of the 103 status code. Using Early Hints is proposed as a (partial) alternative to Server Push, which are going to be removed from Chrome: https://groups.google.com/a/chromium.org/g/blink-dev/c/K3rYLvmQUBY/m/21anpFhxAQAJ Being able to send this status code from servers implemented using Go would help to see if implementing it in browsers is worth it. Fixes #26089 Fixes #36734 Updates #26088 Change-Id: Ib7023c1892c35e8915d4305dd7f6373dbd00a19d GitHub-Last-Rev: 06d749d GitHub-Pull-Request: #42597 Reviewed-on: https://go-review.googlesource.com/c/go/+/269997 Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>

gopherbot · 2022-05-17T16:14:06Z

This PR is being closed because golang.org/cl/269997 has been merged.

Content-Length and Transfer-Encoding must not be sent when the response has no body. Necessary to fix the tests of golang/go#42597. Change-Id: Ibe90048bb122cc3ad1e04f8ebf9aa966b40489ae GitHub-Last-Rev: 2605919 GitHub-Pull-Request: #134 Reviewed-on: https://go-review.googlesource.com/c/net/+/406494 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Damien Neil <dneil@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>

Support for 1xx responses has recently been merged in net/http (golang#42597). As discussed in this CL (https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a), support for forwarding 1xx responses in ReverseProxy has been extracted in this separate patch. According to RFC 7231, "a proxy MUST forward 1xx responses unless the proxy itself requested the generation of the 1xx response". Consequently, all received 1xx responses are automatically forwarded as long as the underlying transport supports ClientTrace.Got1xxResponse.

Support for 1xx responses has recently been merged in net/http (golang#42597). As discussed in this CL (https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a), support for forwarding 1xx responses in ReverseProxy has been extracted in this separate patch. According to RFC 7231, "a proxy MUST forward 1xx responses unless the proxy itself requested the generation of the 1xx response". Consequently, all received 1xx responses are automatically forwarded as long as the underlying transport supports ClientTrace.Got1xxResponse. Fixes golang#26088 Fixes golang#36734

Support for 1xx responses has recently been merged in net/http (golang#42597). As discussed in this CL (https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a), support for forwarding 1xx responses in ReverseProxy has been extracted in this separate patch. According to RFC 7231, "a proxy MUST forward 1xx responses unless the proxy itself requested the generation of the 1xx response". Consequently, all received 1xx responses are automatically forwarded as long as the underlying transport supports ClientTrace.Got1xxResponse. Fixes golang#26088 Fixes golang#51914

Currently, it's not possible to send informational responses such as 103 Early Hints or 102 Processing. This patch allows calling WriteHeader() multiple times in order to send informational responses before the final one. If the status code is in the 1xx range, the current content of the header map is also sent. Its content is not removed after the call to WriteHeader() because the headers must also be included in the final response. The Chrome and Fastly teams are starting a large-scale experiment to measure the real-life impact of the 103 status code. Using Early Hints is proposed as a (partial) alternative to Server Push, which are going to be removed from Chrome: https://groups.google.com/a/chromium.org/g/blink-dev/c/K3rYLvmQUBY/m/21anpFhxAQAJ Being able to send this status code from servers implemented using Go would help to see if implementing it in browsers is worth it. Fixes #26089 Fixes #36734 Updates #26088 Change-Id: Ib7023c1892c35e8915d4305dd7f6373dbd00a19d GitHub-Last-Rev: 06d749d3454aa35c177a50ce4a25715df21fd742 GitHub-Pull-Request: golang/go#42597 Reviewed-on: https://go-review.googlesource.com/c/go/+/269997 Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>

Content-Length and Transfer-Encoding must not be sent when the response has no body. Necessary to fix the tests of golang/go#42597. Change-Id: Ibe90048bb122cc3ad1e04f8ebf9aa966b40489ae GitHub-Last-Rev: 2605919859d0b6b4b5d41da68c8bc3efddea4cbf GitHub-Pull-Request: golang/net#134 Reviewed-on: https://go-review.googlesource.com/c/net/+/406494 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Damien Neil <dneil@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>

Support for 1xx responses has recently been merged in net/http (golang#42597). As discussed in this CL (https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a), support for forwarding 1xx responses in ReverseProxy has been extracted in this separate patch. According to RFC 7231, "a proxy MUST forward 1xx responses unless the proxy itself requested the generation of the 1xx response". Consequently, all received 1xx responses are automatically forwarded as long as the underlying transport supports ClientTrace.Got1xxResponse. Fixes golang#26088 Fixes golang#51914

Content-Length and Transfer-Encoding must not be sent when the response has no body. Necessary to fix the tests of golang/go#42597. Change-Id: Ibe90048bb122cc3ad1e04f8ebf9aa966b40489ae GitHub-Last-Rev: 2605919859d0b6b4b5d41da68c8bc3efddea4cbf GitHub-Pull-Request: golang/net#134 Reviewed-on: https://go-review.googlesource.com/c/net/+/406494 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Damien Neil <dneil@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>

…Early Hints) and other 1XX statuses (dunglas) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [HttpFoundation] Add support for the 103 status code (Early Hints) and other 1XX statuses | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes  | Deprecations? | yes  | Tickets | n/a  | License | MIT | Doc PR | todo This patch adds support for sending informational responses, including [Early Hints responses](https://developer.chrome.com/blog/early-hints/) if supported by the SAPI. It also allows sending other informational status codes such as 102 Processing. According to [Shopify](https://twitter.com/colinbendell/status/1539322190541295616) and [Cloudflare](http://blog.cloudflare.com/early-hints-performance), using Early Hints, the performance improvement to the Largest Contentful Paint can go from several hundred milliseconds, and up to a second faster. Usage: ```php <?php namespace App\Controller; use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; use Symfony\Component\HttpFoundation\Response; use Symfony\Component\Routing\Annotation\Route; use Symfony\Component\WebLink\Link; class HomepageController extends AbstractController { #[Route("/", name: "homepage")] public function index(): Response { $response = $this->sendEarlyHints([ (new Link(href: '/style.css'))->withAttribute('as', 'stylesheet'), (new Link(href: '/script.js'))->withAttribute('as', 'script'), ]); // Do something slow... return $this->render('homepage/index.html.twig', response: $response); } } ``` With this patch, HttpFoundation will leverage the `headers_send()` function provided by [FrankenPHP](https://frankenphp.dev). FrankenPHP is currently the only SAPI supporting Early Hints, but other SAPI such as mod_apache will probably implement this function at some point: php/php-src#7025 (comment) The low-level API is similar to the one provided by Go: golang/go#42597 The high-level API helper in `AbstractController` is similar to Node's one: nodejs/node#44180 Commits ------- 5be52b2 [HttpFoundation] Add support for the 103 status code (Early Hints) and other 1XX statuses

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 13, 2020

dunglas force-pushed the feat/http-103-status-code branch from 86d5d3e to c33edb7 Compare November 14, 2020 10:45

dunglas mentioned this pull request Nov 14, 2020

x/net/http2: allow sending 1xx responses golang/net#87

Closed

amitbasuri approved these changes Nov 26, 2020

View reviewed changes

dunglas force-pushed the feat/http-103-status-code branch from 8979778 to 491d2db Compare February 10, 2021 13:25

dunglas mentioned this pull request Feb 10, 2021

x/net/http2: allow sending 1xx responses golang/net#96

Closed

dunglas mentioned this pull request Feb 17, 2021

allow sending 1xx responses quic-go/quic-go#3047

Merged

dunglas force-pushed the feat/http-103-status-code branch from 491d2db to 81c6f3f Compare March 5, 2021 09:55

docteurklein approved these changes Mar 5, 2021

View reviewed changes

dunglas mentioned this pull request May 25, 2021

Add headers_send_early_and_clear() function for HTTP Early Hints php/php-src#7025

Open

dunglas force-pushed the feat/http-103-status-code branch from 81c6f3f to 57a11d5 Compare May 25, 2021 21:04

dunglas force-pushed the feat/http-103-status-code branch from 57a11d5 to f32be5c Compare July 16, 2021 08:55

dunglas added 5 commits May 17, 2022 18:00

improve tests

6cf95e3

fix tests

75417b5

Brad's review

3e76d05

update gerrit URL

8d84678

fix test error message

06d749d

dunglas force-pushed the feat/http-103-status-code branch from 65e065a to 06d749d Compare May 17, 2022 16:01

gopherbot closed this May 17, 2022

alexander-schranz mentioned this pull request May 18, 2022

Add HTTP 103 Early Hints Fyrd/caniuse#3891

Open

dunglas mentioned this pull request May 31, 2022

net/http/httputil: forward 1xx responses in ReverseProxy #53164

Closed

dunglas mentioned this pull request Oct 20, 2022

proposal: net/http/httptest: add support for 1XX responses #56346

Open

mitar mentioned this pull request Nov 1, 2022

Support 1xx headers felixge/httpsnoop#23

Closed

dunglas mentioned this pull request Nov 6, 2022

[HttpFoundation] Add support for the 103 status code (Early Hints) and other 1XX statuses symfony/symfony#48128

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net/http: allow sending 1xx responses #42597

net/http: allow sending 1xx responses #42597

dunglas commented Nov 13, 2020 •

edited

Loading

gopherbot commented Nov 13, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Dec 1, 2020

gopherbot commented Feb 10, 2021

gopherbot commented Mar 5, 2021

dunglas commented Mar 5, 2021

gopherbot commented May 25, 2021

gopherbot commented Jul 16, 2021

dunglas commented Jul 16, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

net/http: allow sending 1xx responses #42597

net/http: allow sending 1xx responses #42597

Conversation

dunglas commented Nov 13, 2020 • edited Loading

gopherbot commented Nov 13, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Nov 14, 2020

gopherbot commented Dec 1, 2020

gopherbot commented Feb 10, 2021

gopherbot commented Mar 5, 2021

dunglas commented Mar 5, 2021

gopherbot commented May 25, 2021

gopherbot commented Jul 16, 2021

dunglas commented Jul 16, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

gopherbot commented May 17, 2022

dunglas commented Nov 13, 2020 •

edited

Loading