-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go/internal/work/exec: throw an error when buildP is negative #47360
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: 5173e9a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/336751 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Jay Conrod: Patch Set 2: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Fixed a problem where an error would not occur when a negative value was specified for the p flag. Fixes golang#46686
This PR (HEAD: eeef93b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/336751 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 11bba19) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/336751 to see it. Tip: You can toggle comments from me using the |
Message from Yuki Osaki: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
This PR (HEAD: 01077da) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/336751 to see it. Tip: You can toggle comments from me using the |
Message from Jay Conrod: Patch Set 5: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Go Bot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Go Bot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
This PR (HEAD: 614a06f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/336751 to see it. Tip: You can toggle comments from me using the |
Message from Yuki Osaki: Patch Set 5: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Jay Conrod: Patch Set 6: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Go Bot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Go Bot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Bryan C. Mills: Patch Set 6: Code-Review+1 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Jay Conrod: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Jay Conrod: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
This PR (HEAD: e5c5780) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/336751 to see it. Tip: You can toggle comments from me using the |
Message from Yuki Osaki: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Jay Conrod: Patch Set 7: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Go Bot: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Message from Go Bot: Patch Set 7: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/336751. |
Fixed a problem where an error would not occur when a negative value was specified for the p flag. `go build -p=0` now should throw an error. this is my first pr to this project. If there's anything I'm missing, please let me know 🙏 Fixes #46686 Change-Id: I3b19773ef095fad0e0419100d317727c2268699a GitHub-Last-Rev: e5c5780 GitHub-Pull-Request: #47360 Reviewed-on: https://go-review.googlesource.com/c/go/+/336751 Reviewed-by: Jay Conrod <jayconrod@google.com> Trust: Jay Conrod <jayconrod@google.com> Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org>
This PR is being closed because golang.org/cl/336751 has been merged. |
Fixed a problem where an error would not occur
when a negative value was specified for the p flag.
go build -p=0
now should throw an error.
this is my first pr to this project.
If there's anything I'm missing, please let me know 🙏
Fixes #46686