Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: SOCKS5 proxy with empty password should be allowed #57286

Closed
wants to merge 1 commit into from

Conversation

iseki0
Copy link

@iseki0 iseki0 commented Dec 13, 2022

The behavior is accepted widely, and I found no reason to deny it.

Fixed: #57285

The behavior is accepted widely, and I found no reason to deny it.
@gopherbot
Copy link
Contributor

This PR (HEAD: c8ae772) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/457155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/457155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 2:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/457155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from iseki:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/457155.
After addressing review feedback, remember to publish your drafts!

@iseki0 iseki0 closed this Dec 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/net/proxy: SOCKS5 proxy should allow empty password
2 participants