encoding/json: add omitzero option #69622

callthingsoff · 2024-09-25T12:17:17Z

Fixes #45669

gopherbot · 2024-09-25T12:27:13Z

This PR (HEAD: aacdc51) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-25T12:34:53Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-25T14:02:28Z

Message from Ian Lance Taylor:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T12:56:10Z

This PR (HEAD: 903dea1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-26T13:12:13Z

This PR (HEAD: 7732db3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-26T14:06:36Z

Message from Ian Lance Taylor:

Patch Set 3:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T14:30:43Z

This PR (HEAD: e61c805) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-26T21:07:37Z

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T21:14:49Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-26T20:58:08Z","revision":"ec210ae082943af52d8f8c447ad7a6a82aea31d8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T21:28:46Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T21:28:46Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T21:28:47Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T22:41:42Z

Message from Ian Lance Taylor:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T22:41:42Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-26T22:30:47Z","revision":"ec210ae082943af52d8f8c447ad7a6a82aea31d8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T22:55:56Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T22:55:57Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T22:55:58Z

Message from Joe Tsai:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T23:03:04Z

Message from Ian Lance Taylor:

Patch Set 4: -Auto-Submit -Code-Review Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T23:03:05Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-26T22:54:06Z","revision":"ec210ae082943af52d8f8c447ad7a6a82aea31d8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T23:23:29Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T23:23:29Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T23:37:11Z

Message from Joe Tsai:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T08:01:44Z

Message from bcd a:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T13:26:49Z

This PR (HEAD: dbedf54) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-27T15:19:11Z

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T15:19:12Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-27T15:14:20Z","revision":"de52b57eda66943aa2d6490122de568611dedb16"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-27T15:48:18Z

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

Change-Id: I3d8ffdfaf3478adcaca09615908f6f9b065165fc

Change-Id: I94aaf74a58984f022c6078ca39f85c761c7607e4

Change-Id: Ia04b14d1c08fd8c9bce0c36d526bf68f7c5eced1

Change-Id: Iade683ed5c91d148096e4b80f8c5807697afc134

Change-Id: I49a2c48613ea2b06dd119398279e82683559de59

Change-Id: I49f14328841cc2e950e244f4cd98c4dcea1f0987

gopherbot · 2024-10-01T03:15:11Z

This PR (HEAD: 57030f2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/615676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-01T10:21:09Z

Message from Zxilly Chou:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T17:34:27Z

Message from Joseph Tsai:

Patch Set 8: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T21:44:38Z

Message from Jes Cok:

Patch Set 8:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T21:44:38Z

Message from Jes Cok:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T21:44:38Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-01T21:36:31Z","revision":"60458dde180dc7c27a639fcbfe218a02633aeb40"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T21:44:39Z

Message from Joseph Tsai:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T22:05:34Z

Message from Jes Cok:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T22:05:34Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T22:05:34Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T22:32:38Z

Message from Jes Cok:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T22:46:12Z

Message from Ian Lance Taylor:

Patch Set 8: Auto-Submit+1 Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T22:46:12Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-01T22:38:34Z","revision":"60458dde180dc7c27a639fcbfe218a02633aeb40"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T23:07:29Z

Message from Ian Lance Taylor:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-01T23:07:29Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/615676.
After addressing review feedback, remember to publish your drafts!

Fixes #45669 Change-Id: Ic13523c0b3acdfc5b3e29a717bc62fde302ed8fd GitHub-Last-Rev: 57030f2 GitHub-Pull-Request: #69622 Reviewed-on: https://go-review.googlesource.com/c/go/+/615676 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Joseph Tsai <joetsai@digital-static.net> Reviewed-by: Michael Knyszek <mknyszek@google.com>

gopherbot · 2024-10-02T14:31:38Z

This PR is being closed because golang.org/cl/615676 has been merged.

Fixes golang#45669 Change-Id: Ic13523c0b3acdfc5b3e29a717bc62fde302ed8fd GitHub-Last-Rev: 57030f2 GitHub-Pull-Request: golang#69622 Reviewed-on: https://go-review.googlesource.com/c/go/+/615676 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Joseph Tsai <joetsai@digital-static.net> Reviewed-by: Michael Knyszek <mknyszek@google.com>

callthingsoff force-pushed the encoding_json_omitzero branch 2 times, most recently from 3de4cb2 to 903dea1 Compare September 26, 2024 12:55

callthingsoff force-pushed the encoding_json_omitzero branch from e61c805 to dbedf54 Compare September 27, 2024 13:24

callthingsoff added 6 commits October 1, 2024 10:18

5

b3d28f6

Change-Id: I3d8ffdfaf3478adcaca09615908f6f9b065165fc

6

92a4ba3

Change-Id: I94aaf74a58984f022c6078ca39f85c761c7607e4

7

1270b2f

Change-Id: Ia04b14d1c08fd8c9bce0c36d526bf68f7c5eced1

8

b5a7e68

Change-Id: Iade683ed5c91d148096e4b80f8c5807697afc134

9

0b672df

Change-Id: I49a2c48613ea2b06dd119398279e82683559de59

10

57030f2

Change-Id: I49f14328841cc2e950e244f4cd98c4dcea1f0987

callthingsoff force-pushed the encoding_json_omitzero branch from 299c0d4 to 57030f2 Compare October 1, 2024 03:10

lawchingman approved these changes Oct 1, 2024

View reviewed changes

gopherbot closed this Oct 2, 2024

callthingsoff deleted the encoding_json_omitzero branch October 3, 2024 00:41

bradfitz mentioned this pull request Dec 16, 2024

encoding/json: add omitzero option tailscale/go#108

Merged

encoding/json: add omitzero option #69622

encoding/json: add omitzero option #69622

Conversation

callthingsoff commented Sep 25, 2024

gopherbot commented Sep 25, 2024

gopherbot commented Sep 25, 2024

gopherbot commented Sep 25, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 27, 2024

gopherbot commented Sep 27, 2024

gopherbot commented Sep 27, 2024

gopherbot commented Sep 27, 2024

gopherbot commented Sep 27, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 1, 2024

gopherbot commented Oct 2, 2024