Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Update documentation on MinTimes and MaxTimes. Closes #331 #334

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

rkpatel7
Copy link
Contributor

Updated the documentation to something I think seems to be clearer. Also added two tests for this.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rkpatel7 rkpatel7 force-pushed the update-min-max-times-documentation branch from 1913245 to 5fc2922 Compare October 18, 2019 22:24
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@rkpatel7
Copy link
Contributor Author

It's a little unfortunate the CLA requires the commit to include a public email address. It would be nice if it worked with the github no-reply email address. I ended up having to make a separate gmail account to sign the CLA and associate with this commit.

@codyoss
Copy link
Member

codyoss commented Oct 22, 2019

@rkpatel7 Yeah, I am not sure if there is a way around that one. But I appreciate you going thought all of the trouble!

@codyoss codyoss merged commit 0e690d0 into golang:master Oct 22, 2019
@rkpatel7 rkpatel7 deleted the update-min-max-times-documentation branch October 28, 2019 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants