Skip to content

Commit

Permalink
quic: temporarily disable networking tests failing on various platforms
Browse files Browse the repository at this point in the history
For golang/go#65906
For golang/go#65907

Change-Id: I5fe83a27f47b6f2337d280465bf134dbd883809d
Reviewed-on: https://go-review.googlesource.com/c/net/+/566098
Auto-Submit: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
  • Loading branch information
neild authored and gopherbot committed Feb 23, 2024
1 parent 4bdc6df commit 34cc446
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/quic/udp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
)

func TestUDPSourceUnspecified(t *testing.T) {
t.Skip("https://go.dev/issue/65906 - temporarily skipped pending fix")
// Send datagram with no source address set.
runUDPTest(t, func(t *testing.T, test udpTest) {
data := []byte("source unspecified")
Expand All @@ -33,6 +34,7 @@ func TestUDPSourceUnspecified(t *testing.T) {
}

func TestUDPSourceSpecified(t *testing.T) {
t.Skip("https://go.dev/issue/65906 - temporarily skipped pending fix")
// Send datagram with source address set.
runUDPTest(t, func(t *testing.T, test udpTest) {
data := []byte("source specified")
Expand All @@ -51,6 +53,7 @@ func TestUDPSourceSpecified(t *testing.T) {
}

func TestUDPSourceInvalid(t *testing.T) {
t.Skip("https://go.dev/issue/65906 - temporarily skipped pending fix")
// Send datagram with source address set to an address not associated with the connection.
if !udpInvalidLocalAddrIsError {
t.Skipf("%v: sending from invalid source succeeds", runtime.GOOS)
Expand All @@ -74,6 +77,7 @@ func TestUDPSourceInvalid(t *testing.T) {
}

func TestUDPECN(t *testing.T) {
t.Skip("https://go.dev/issue/65907 - temporarily skipped pending fix")
if !udpECNSupport {
t.Skipf("%v: no ECN support", runtime.GOOS)
}
Expand Down

0 comments on commit 34cc446

Please sign in to comment.