Rename Children to ChildNodes

golang · Oct 28, 2024 · bb50757 · bb50757
1 parent ac0b9cf
commit bb50757
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/html/iter.go b/html/iter.go
@@ -24,15 +24,15 @@ func (n *Node) Ancestors() iter.Seq[*Node] {
 	}
 }
 
-// Children returns an iterator over the immediate children of n,
+// ChildNodes returns an iterator over the immediate children of n,
 // starting with n.FirstChild.
 //
 // Example:
 //
-//	for child := range n.Children() { ... }
+//	for child := range n.ChildNodes() { ... }
 //
 // Mutating a Node or its children while iterating may have unexpected results.
-func (n *Node) Children() iter.Seq[*Node] {
+func (n *Node) ChildNodes() iter.Seq[*Node] {
 	_ = n.FirstChild // eager nil check
 
 	return func(yield func(*Node) bool) {
@@ -59,7 +59,7 @@ func (n *Node) Descendants() iter.Seq[*Node] {
 }
 
 func (n *Node) descendants(yield func(*Node) bool) bool {
-	for c := range n.Children() {
+	for c := range n.ChildNodes() {
 		if !yield(c) || !c.descendants(yield) {
 			return false
 		}

diff --git a/html/iter_test.go b/html/iter_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 )
 
-func TestNode_Children(t *testing.T) {
+func TestNode_ChildNodes(t *testing.T) {
 	tests := []struct {
 		in   string
 		want string
@@ -32,11 +32,11 @@ func TestNode_Children(t *testing.T) {
 		// Drill to <html><head></head><body>
 		n := doc.FirstChild.FirstChild.NextSibling
 		var results []string
-		for c := range n.Children() {
+		for c := range n.ChildNodes() {
 			results = append(results, c.Data)
 		}
 		if got := strings.Join(results, " "); got != test.want {
-			t.Errorf("unexpected children yielded by Children; want: %q got: %q", test.want, got)
+			t.Errorf("unexpected children yielded by ChildNodes; want: %q got: %q", test.want, got)
 		}
 	}
 }