Commits on Jul 8, 2024

1. html: sync changes from std …

   Before golang/go@324513b (2012-01-04) std "html" and what is now
   "golang.org/x/net/html" were the same. Ever since then (well, since
   golang/go@4e0749a (2012-05-29)) the escape/unescape code that they
   share has been drifting apart, each receiving separate improvements.
   
   This CL cherry-picks over all of the changes that std "html" has seen.
   
   When applying golang/go@5b92028 (https://golang.org/cl/10172) I had to
   get a touch creative.  That commit inlined `unescape()` into
   `UnescapeString()`, removing the original `unescape()`.  However, over
   here in x/net, we have other callers of `unescape()` so we can't
   remove it... but duplicating it is also bad.  Simply wrapping it
   instead of duplicating it would repeat the first call to `IndexByte()`
   (first as `strings.IndexByte()`, then as `bytes.IndexByte()`); as
   minor as that preformance regression would be, I don't want anything
   to go backward.  So, I've pulled out an `unescapeInner()` function
   takes the initial `i` as an argument, and both `unescape()` and
   `UnescapeString()` call.
   
   This is the counterpart to https://golang.org/cl/580896, and so also
   includes the doc-fix for `UnescapeString()` requested at
   https://go-review.googlesource.com/c/go/+/580896/comment/cc8b5704_b1899241/
   
   golang/go@a025e1c :
   
       Author: Shawn Smith <shawn.p.smith@gmail.com>
       Date:   Wed Dec 18 10:20:25 2013 -0800
   
       html: add tests for UnescapeString edge cases
   
       R=golang-dev, gobot, bradfitz
       CC=golang-dev
       https://golang.org/cl/40810044
   
   golang/go@2d9a50b :
   
       Author: Didier Spezia <didier.06@gmail.com>
       Date:   Fri May 8 16:38:08 2015 +0000
   
       html: simplify and optimize escape/unescape
   
       The html package uses some specific code to escape special characters.
       Actually, the strings.Replacer can be used instead, and is much more
       efficient. The converse operation is more complex but can still be
       slightly optimized.
   
       Credits to Ken Bloom (kabloom@google.com), who first submitted a
       similar patch at https://codereview.appspot.com/141930043
   
       Added benchmarks and slightly optimized UnescapeString.
   
       benchmark                   old ns/op     new ns/op     delta
       BenchmarkEscape-4           118713        19825         -83.30%
       BenchmarkEscapeNone-4       87653         3784          -95.68%
       BenchmarkUnescape-4         24888         23417         -5.91%
       BenchmarkUnescapeNone-4     14423         157           -98.91%
   
       benchmark                   old allocs     new allocs     delta
       BenchmarkEscape-4           9              2              -77.78%
       BenchmarkEscapeNone-4       0              0              +0.00%
       BenchmarkUnescape-4         2              2              +0.00%
       BenchmarkUnescapeNone-4     0              0              +0.00%
   
       benchmark                   old bytes     new bytes     delta
       BenchmarkEscape-4           24800         12288         -50.45%
       BenchmarkEscapeNone-4       0             0             +0.00%
       BenchmarkUnescape-4         10240         10240         +0.00%
       BenchmarkUnescapeNone-4     0             0             +0.00%
   
       Fixes #8697
   
       Change-Id: I208261ed7cbe9b3dee6317851f8c0cf15528bce4
       Reviewed-on: https://go-review.googlesource.com/9808
       Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
       Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
       TryBot-Result: Gobot Gobot <gobot@golang.org>
   
   golang/go@a3c0730 :
   
       Author: Carlos C <uldericofilho@gmail.com>
       Date:   Wed Jun 17 23:51:54 2015 +0200
   
       html: add examples to the functions
   
       Change-Id: I129d70304ae4e4694d9217826b18b341e3834d3c
       Reviewed-on: https://go-review.googlesource.com/11201
       Reviewed-by: Andrew Gerrand <adg@golang.org>
   
   golang/go@5b92028 :
   
       Author: Ingo Oeser <nightlyone@googlemail.com>
       Date:   Sat May 9 17:55:05 2015 +0200
   
       html: speed up UnescapeString
   
       Add benchmarks for for sparsely escaped and densely escaped strings.
       Then speed up the sparse unescaping part heavily by using IndexByte and
       copy to skip the parts containing no escaping very fast.
   
       Unescaping densely escaped strings slower because of
       the new function call overhead. But sparsely encoded strings are seen
       more often in the utf8 enabled web.
   
       We win part of the speed back by looking up entityName differently.
   
       	benchmark                  old ns/op    new ns/op    delta
       	BenchmarkEscape                31680        31396   -0.90%
       	BenchmarkEscapeNone             6507         6872   +5.61%
       	BenchmarkUnescape              36481        48298  +32.39%
       	BenchmarkUnescapeNone            332          325   -2.11%
       	BenchmarkUnescapeSparse         8836         3221  -63.55%
       	BenchmarkUnescapeDense         30639        32224   +5.17%
   
       Change-Id: If606cb01897a40eefe35ba98f2ff23bb25251606
       Reviewed-on: https://go-review.googlesource.com/10172
       Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
       Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
       TryBot-Result: Gobot Gobot <gobot@golang.org>
   
   golang/go@a44c425 :
   
       Author: Brad Fitzpatrick <bradfitz@golang.org>
       Date:   Sun Apr 10 14:51:07 2016 +0000
   
       html: fix typo in UnescapeString string docs
   
       Fixes #15221
   
       Change-Id: I9e927a2f604213338b4572f1a32d0247c58bdc60
       Reviewed-on: https://go-review.googlesource.com/21798
       Reviewed-by: Ian Lance Taylor <iant@golang.org>
   
   golang/go@6dae588 :
   
       Author: Seiji Takahashi <timaki.st@gmail.com>
       Date:   Thu Aug 3 22:08:55 2017 +0900
   
       html: updated entity spec link
   
       Fixes #21194
   
       Change-Id: Iac5187335df67f90f0f47c7ef6574de147c2ac9b
       Reviewed-on: https://go-review.googlesource.com/52970
       Reviewed-by: Avelino <t@avelino.xxx>
       Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
   
   golang/go@740e589 :
   
       Author: Brad Fitzpatrick <bradfitz@golang.org>
       Date:   Tue Jul 31 21:37:35 2018 +0000
   
       html: lazily populate Unescape tables
   
       Saves ~105KB of heap for callers who don't use html.UnescapeString.
       (EscapeString is much more common).
   
       Also saves 70KB of binary size, because now the linker can do dead
       code elimination. (because #2559 is still open and global maps always
       generate init code)
   
       Fixes #26727
       Updates #6853
   
       Change-Id: I18fe9a273097e2c7e0cb7f88205cae1bb60fa89b
       Reviewed-on: https://go-review.googlesource.com/127075
       Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
       Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
       Reviewed-by: Ian Lance Taylor <iant@golang.org>
       TryBot-Result: Gobot Gobot <gobot@golang.org>
   
   golang/go@4ad1355 :
   
       Author: Romain Baugue <romain.baugue@elwinar.com>
       Date:   Tue Apr 30 13:51:05 2019 +0200
   
       html: add a Fuzz function
   
       Adds a sample Fuzz test function to package html based on
       https://github.com/dvyukov/go-fuzz-corpus/blob/master/stdhtml/main.go
   
       Updates #19109
       Updates #31309
   
       Change-Id: I8c49fff8f70fc8a8813daf1abf0044752003adbb
       Reviewed-on: https://go-review.googlesource.com/c/go/+/174301
       Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
       Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
       TryBot-Result: Gobot Gobot <gobot@golang.org>
   
   golang/go@52c4488 :
   
       Author: fujimoto kyosuke <kyoro.f@gmail.com>
       Date:   Sun Jan 12 06:49:19 2020 +0000
   
       html: update URL in comment
   
       The comment contained a link that had a file name and ID that no longer existed, so change to the URL of the corresponding part of the latest page.
   
       Change-Id: I74e0885aabf470facc39b84035f7a83fef9c6a8e
       GitHub-Last-Rev: 5681c84d9f1029449da6860c65a1d9a128296e85
       GitHub-Pull-Request: golang/go#36514
       Reviewed-on: https://go-review.googlesource.com/c/go/+/214181
       Run-TryBot: Ian Lance Taylor <iant@golang.org>
       TryBot-Result: Gobot Gobot <gobot@golang.org>
       Reviewed-by: Ian Lance Taylor <iant@golang.org>
   
   golang/go@d4b2638 :
   
       Author: Russ Cox <rsc@golang.org>
       Date:   Fri Feb 19 18:35:10 2021 -0500
   
       all: go fmt std cmd (but revert vendor)
   
       Make all our package sources use Go 1.17 gofmt format
       (adding //go:build lines).
   
       Part of //go:build change (#41184).
       See https://golang.org/design/draft-gobuild
   
       Change-Id: Ia0534360e4957e58cd9a18429c39d0e32a6addb4
       Reviewed-on: https://go-review.googlesource.com/c/go/+/294430
       Trust: Russ Cox <rsc@golang.org>
       Run-TryBot: Russ Cox <rsc@golang.org>
       TryBot-Result: Go Bot <gobot@golang.org>
       Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
       Reviewed-by: Ian Lance Taylor <iant@golang.org>
   
   golang/go@f229e70 :
   
       Author: Russ Cox <rsc@golang.org>
       Date:   Wed Aug 25 12:48:26 2021 -0400
   
       all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor)
   
       When these packages are released as part of Go 1.18,
       Go 1.16 will no longer be supported, so we can remove
       the +build tags in these files.
   
       Ran go fix -fix=buildtag std cmd and then reverted the bootstrapDirs
       as defined in src/cmd/dist/buildtool.go, which need to continue
       to build with Go 1.4 for now.
   
       Also reverted src/vendor and src/cmd/vendor, which will need
       to be updated in their own repos first.
   
       Manual changes in runtime/pprof/mprof_test.go to adjust line numbers.
   
       For #41184.
   
       Change-Id: Ic0f93f7091295b6abc76ed5cd6e6746e1280861e
       Reviewed-on: https://go-review.googlesource.com/c/go/+/344955
       Trust: Russ Cox <rsc@golang.org>
       Run-TryBot: Russ Cox <rsc@golang.org>
       TryBot-Result: Go Bot <gobot@golang.org>
       Reviewed-by: Bryan C. Mills <bcmills@google.com>
   
   golang/go@200a01f :
   
       Author: Tobias Klauser <tklauser@distanz.ch>
       Date:   Wed May 10 17:08:59 2023 +0200
   
       html: convert fuzz test to native Go fuzzing
   
       Convert the existing gofuzz based fuzz test to a testing.F based fuzz
       test.
   
       Change-Id: Ieae69ba7fb17bd54d95c7bb2f4ed04c323c9f15f
       Reviewed-on: https://go-review.googlesource.com/c/go/+/494195
       TryBot-Result: Gopher Robot <gobot@golang.org>
       Reviewed-by: Ian Lance Taylor <iant@google.com>
       Reviewed-by: Cherry Mui <cherryyz@google.com>
       Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
       Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>

   

   LukeShu committed Jul 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 757e15b
   • Browse repository at this point

   Copy the full SHA

   757e15b View commit details

   Browse the repository at this point in the history