google: base account credentials with file-sourcing #462

gIthuriel · 2020-12-03T20:55:25Z

Implements the core functionality to allow 3rd party identities access to Google APIs. Specifically, this PR implements the base account credential type and supports file-sourced credentials such as Kubernetes workloads. Later updates will add support for URL-sourced credentials such as Microsoft Azure and support for AWS credentials.

google-cla · 2020-12-03T20:55:31Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-03T21:06:14Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-03T21:10:40Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-07T22:13:44Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-07T22:40:29Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

gIthuriel · 2020-12-07T22:42:57Z

@googlebot You should run this again now?

google-cla · 2020-12-07T22:43:05Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

gopherbot · 2020-12-08T20:51:04Z

This PR (HEAD: 9d33034) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-12-09T22:30:31Z

Message from Patrick Jones:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-10T22:23:22Z

Message from Cody Oss:

Patch Set 1: Code-Review-1

(31 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-10T22:58:24Z

Message from Patrick Jones:

Patch Set 1:

(21 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-10T23:09:16Z

Message from Shin Fan:

Patch Set 1: Code-Review-1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

Change-Id: I8c5c60f03b537834c59420c1f096ef97f9ada8c2

gopherbot · 2020-12-10T23:23:41Z

This PR (HEAD: 27c17b4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-12-10T23:25:47Z

Message from Patrick Jones:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-10T23:25:48Z

Message from Chuan Ren:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-14T18:59:45Z

Message from Cody Oss:

Patch Set 2:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

… to allow for testing for time in unit tests. The unit tests will not pass at the moment; awaiting feedback on whether to use a test credential source or rely on a separate one. Change-Id: I20605fa161911f325ab41fc345436d08ed17ed5e

gopherbot · 2020-12-14T20:52:40Z

This PR (HEAD: 4c1e086) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-12-14T20:57:12Z

Message from Patrick Jones:

Patch Set 3:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-15T15:25:23Z

Message from Cody Oss:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

Change-Id: Ic0e6363b19bbfd40df6b7b15322abf43c9990688

gopherbot · 2020-12-15T16:55:17Z

This PR (HEAD: 08114d0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Change-Id: I741fc5df06f9fa06cf15dd04cba3ff9fbb90e880

gopherbot · 2021-01-08T00:35:39Z

This PR (HEAD: c37859f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-08T00:39:27Z

Message from Patrick Jones:

Patch Set 9:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-08T20:12:35Z

Message from Cody Oss:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

Change-Id: I1cd741935fd5e4b7fca70395285f8e458c6e0ae3

gopherbot · 2021-01-08T20:36:56Z

This PR (HEAD: d16feb8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-08T20:38:54Z

Message from Patrick Jones:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-11T15:12:21Z

Message from Cody Oss:

Patch Set 10:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

Change-Id: I5164549afe6997f4512c9dc1954b97ca7a2c6c4d

gopherbot · 2021-01-11T19:27:20Z

This PR (HEAD: 3bbb436) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-11T19:29:22Z

Message from Patrick Jones:

Patch Set 10:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

Change-Id: Ia1f314ae5edd33bc91b5e950c6499c049219ee79

gopherbot · 2021-01-11T21:03:54Z

This PR (HEAD: 5e41ced) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-11T21:05:59Z

Message from Patrick Jones:

Patch Set 11:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T17:11:36Z

Message from Cody Oss:

Patch Set 12: Run-TryBot+1 Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T17:11:37Z

Message from Go Bot:

Patch Set 12:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=9d79c306

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T17:13:38Z

Message from Go Bot:

Patch Set 12: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T19:41:45Z

Message from Tyler Bui-Palsulich:

Patch Set 12:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

Change-Id: I2dc28d4f427509b3e62eeb9f14b1583178812038

gopherbot · 2021-01-12T19:45:51Z

This PR (HEAD: 3ab5162) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/276312 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-12T19:59:30Z

Message from Patrick Jones:

Patch Set 12:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T20:03:27Z

Message from Tyler Bui-Palsulich:

Patch Set 13: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T20:03:28Z

Message from Go Bot:

Patch Set 13:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a9479931

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

Implements the core functionality to allow 3rd party identities access to Google APIs. Specifically, this PR implements the base account credential type and supports file-sourced credentials such as Kubernetes workloads. Later updates will add support for URL-sourced credentials such as Microsoft Azure and support for AWS credentials. Change-Id: I6e09a450f5221a1e06394b51374cff70ab3ab8a7 GitHub-Last-Rev: 3ab5162 GitHub-Pull-Request: #462 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/276312 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Trust: Tyler Bui-Palsulich <tbp@google.com> Trust: Cody Oss <codyoss@google.com> Run-TryBot: Tyler Bui-Palsulich <tbp@google.com> TryBot-Result: Go Bot <gobot@golang.org>

gopherbot · 2021-01-12T20:05:27Z

Message from Go Bot:

Patch Set 13: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/276312.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T20:07:27Z

This PR is being closed because golang.org/cl/276312 has been merged.

Implements functionality to allow for URL-sourced 3rd party credentials, expanding the functionality added in #462 . Change-Id: Ib7615fb618486612960d60bee6b9a1ecf5de1404 GitHub-Last-Rev: 9571392 GitHub-Pull-Request: #466 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/283372 Run-TryBot: Cody Oss <codyoss@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cody Oss <codyoss@google.com> Trust: Tyler Bui-Palsulich <tbp@google.com> Trust: Cody Oss <codyoss@google.com>

google-cla bot added the cla: no label Dec 3, 2020

gIthuriel force-pushed the base-account-credentials branch from 55ce29d to 237dff9 Compare December 7, 2020 22:40

google: base account credential support

9d33034

gIthuriel force-pushed the base-account-credentials branch from 237dff9 to 9d33034 Compare December 8, 2020 20:32

google-cla bot added cla: yes and removed cla: no labels Dec 8, 2020

google: addressed formatting feedback

27c17b4

Change-Id: I8c5c60f03b537834c59420c1f096ef97f9ada8c2

gIthuriel changed the title ~~Base account credentials with file-sourcing~~ google: base account credentials with file-sourcing Dec 15, 2020

google: minor tweaks

08114d0

Change-Id: Ic0e6363b19bbfd40df6b7b15322abf43c9990688

Bring some tests up to match some current changes.

c37859f

Change-Id: I741fc5df06f9fa06cf15dd04cba3ff9fbb90e880

Fixed style nit.

d16feb8

Change-Id: I1cd741935fd5e4b7fca70395285f8e458c6e0ae3

Update some nits

3bbb436

Change-Id: I5164549afe6997f4512c9dc1954b97ca7a2c6c4d

Changed some test formatting.

5e41ced

Change-Id: Ia1f314ae5edd33bc91b5e950c6499c049219ee79

Fixed Tyler's nits

3ab5162

Change-Id: I2dc28d4f427509b3e62eeb9f14b1583178812038

gopherbot closed this Jan 12, 2021

gIthuriel mentioned this pull request Jan 12, 2021

google: support url-sourced 3rd party credentials #466

Closed

apstndb mentioned this pull request Aug 10, 2021

IAM: support STS token source googleapis/google-api-go-client#750

Open

google: base account credentials with file-sourcing #462

google: base account credentials with file-sourcing #462

Conversation

gIthuriel commented Dec 3, 2020

google-cla bot commented Dec 3, 2020

google-cla bot commented Dec 3, 2020

google-cla bot commented Dec 3, 2020

google-cla bot commented Dec 7, 2020

google-cla bot commented Dec 7, 2020

gIthuriel commented Dec 7, 2020

google-cla bot commented Dec 7, 2020

gopherbot commented Dec 8, 2020

gopherbot commented Dec 9, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 14, 2020

gopherbot commented Dec 14, 2020

gopherbot commented Dec 14, 2020

gopherbot commented Dec 15, 2020

gopherbot commented Dec 15, 2020

gopherbot commented Jan 8, 2021

gopherbot commented Jan 8, 2021

gopherbot commented Jan 8, 2021

gopherbot commented Jan 8, 2021

gopherbot commented Jan 8, 2021

gopherbot commented Jan 11, 2021

gopherbot commented Jan 11, 2021

gopherbot commented Jan 11, 2021

gopherbot commented Jan 11, 2021

gopherbot commented Jan 11, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021