design: add proposal doc for 33974

[azr]

Make the cmd/internal/lockedfile Package public.

Updates golang/go#33974

[gopherbot]

This PR (HEAD: e5023c7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 6898178) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 0c9e80a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 4207027) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Adrien Delorme:

Patch Set 4:

(1 comment)

Okay, I've added the exported names from the godoc :) !

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 4:

(12 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: dfd8558) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 9f6c5eb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: de50d4f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 0a58501) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: e410302) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 3a99c89) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Adrien Delorme:

Patch Set 11:

(13 comments)

I applied some changes after reviews. Thanks for bearing with me :)

I already added it in the comments but I wanted to add that lockedfile.File sorts of stutters and may be depending on where these types will reside we should change it.

And I think it would be a good idea to answer this question first :).

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Adrien Delorme:

Patch Set 14:

Hello there, sorry for this impromptu bump, but do we have any news on this ? May be I should leave the lead to Bryan C. Mills as he's the original author and the back and forth would be more seamless ?

Have a great dayo !
A.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 14:

Patch Set 14:

Hello there, sorry for this impromptu bump, but do we have any news on this ? May be I should leave the lead to Bryan C. Mills as he's the original author and the back and forth would be more seamless ?

Sorry, I got a bit distracted by pre-freeze work. I'll do another pass on this shortly.

Note that there is a new addition to the lockedfile package in CL 205637 that seems to address a fairly common use-case.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 9b55e8f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 402cae2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Adrien Delorme:

Patch Set 15:

Patch Set 14:

Patch Set 14:

Hello there, sorry for this impromptu bump, but do we have any news on this ? May be I should leave the lead to Bryan C. Mills as he's the original author and the back and forth would be more seamless ?

Sorry, I got a bit distracted by pre-freeze work. I'll do another pass on this shortly.

Note that there is a new addition to the lockedfile package in CL 205637 that seems to address a fairly common use-case.

Hello there, no worries :) and thanks for the heads up I added Transform to the document.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 16:

(10 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: d6be79e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/201277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Adrien Delorme:

Patch Set 16:

(8 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 17:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 17: Code-Review+2

LGTM to submit as a design doc, but let me know if you would like to hold off for Solaris / AIX revisions.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/201277.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/201277 has been merged.