execabs: isGo119ErrDot: use errors.Is instead of string-matching #142
Conversation
|
This PR (HEAD: d72f1b8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/448877 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
|
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
|
Message from Ian Lance Taylor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
thaJeztah
force-pushed
the
execabs_no_string_matching
branch
from
d72f1b8
to
99ba4c2
Compare
|
This PR (HEAD: 99ba4c2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/448877 to see it. Tip: You can toggle comments from me using the |
|
Message from Sebastiaan van Stijn: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
|
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
thaJeztah
changed the title
Addresses the TODO added in CL 403256. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
execabs_no_string_matching
branch
from
99ba4c2
to
1adfdb7
Compare
|
This PR (HEAD: 1adfdb7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/448877 to see it. Tip: You can toggle comments from me using the |
|
Message from Sebastiaan van Stijn: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
|
Message from Sebastiaan van Stijn: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
|
Message from Ian Lance Taylor: Patch Set 3: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448877. |
Addresses the TODO added in CL 403256. Change-Id: Iae44242e00b6a309cc0f1e336462bc2d4995a5e2 GitHub-Last-Rev: 1adfdb7 GitHub-Pull-Request: #142 Reviewed-on: https://go-review.googlesource.com/c/sys/+/448877 Auto-Submit: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
|
This PR is being closed because golang.org/cl/448877 has been merged. |
Addresses the TODO added in CL 403256.