New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: fix constant values for JobObjectInformationClass #150

Closed

masshash wants to merge 1 commit into golang:master from masshash:fix-JobObjectInformationClass-constant-values

+2 −2

Contributor

masshash commented Mar 25, 2023

The constant values were incorrect and has been fixed in this CL.

Reference:
https://learn.microsoft.com/en-us/windows/win32/api/jobapi2/nf-jobapi2-setinformationjobobject#parameters


          windows: fix constant values for JobObjectInformationClass

cd1e32d

The constant values were incorrect and has been fixed in this CL.

Reference:
https://learn.microsoft.com/en-us/windows/win32/api/jobapi2/nf-jobapi2-setinformationjobobject#parameters

gopherbot commented Mar 25, 2023

This PR (HEAD: cd1e32d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/479375 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Mar 25, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/479375.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 28, 2023

Message from Alex Brainman:

Patch Set 1: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/479375.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 28, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/479375.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 28, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/479375.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 28, 2023

Message from Ian Lance Taylor:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/479375.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 28, 2023

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/479375.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          windows: fix constant values for JobObjectInformationClass

94933fc

The constant values were incorrect and has been fixed in this CL.

Reference:
https://learn.microsoft.com/en-us/windows/win32/api/jobapi2/nf-jobapi2-setinformationjobobject#parameters

Change-Id: Id97e561b6838a18216617d86aa11c79b6b2f4095
GitHub-Last-Rev: cd1e32d
GitHub-Pull-Request: #150
Reviewed-on: https://go-review.googlesource.com/c/sys/+/479375
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>

gopherbot commented Mar 29, 2023

This PR is being closed because golang.org/cl/479375 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment