Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/svc/mgr: Service.Control: populate Status when returning certain errors #156

Closed
wants to merge 7 commits into from

Conversation

craig65535
Copy link
Contributor

@craig65535 craig65535 commented Apr 15, 2023

@gopherbot
Copy link

This PR (HEAD: a4b8c5b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@craig65535
Copy link
Contributor Author

craig65535 commented Apr 15, 2023

In the next few days I'll look into whether adding a test for this is feasible.

Added a test.

@gopherbot
Copy link

This PR (HEAD: 9859284) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 5a7b72a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 1c3db80) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@craig65535 craig65535 changed the title Service.Control: set State and Accepted when returning certain errors windows/svc/mgr: Service.Control: set State and Accepted when returning certain errors Apr 15, 2023
@craig65535 craig65535 changed the title windows/svc/mgr: Service.Control: set State and Accepted when returning certain errors windows/svc/mgr: Service.Control: set Status when returning certain errors Apr 15, 2023
@craig65535 craig65535 changed the title windows/svc/mgr: Service.Control: set Status when returning certain errors windows/svc/mgr: Service.Control: populate Status when returning certain errors Apr 15, 2023
@alexbrainman
Copy link
Member

In the next few days I'll look into whether adding a test for this is feasible.

Added a test.

Let's continue conversation in Gerrit

https://go-review.googlesource.com/c/sys/+/484895

Alex

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 6: Run-TryBot+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Craig Davison:

Patch Set 7:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 7: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 4c0bcbb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Craig Davison:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 8: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 8: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 8: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Bryan Mills:

Patch Set 8: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 929aeb4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Craig Davison:

Patch Set 9:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 9: Code-Review+2 Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 9:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 9: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 9:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Dmitri Shuralyov:

Patch Set 9: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/484895.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 25, 2023
…ain errors

Fixes golang/go#59015

Change-Id: I45f22049f3a05f807f78d20c9ed67c6c79e3d3c1
GitHub-Last-Rev: 929aeb4
GitHub-Pull-Request: #156
Reviewed-on: https://go-review.googlesource.com/c/sys/+/484895
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/484895 has been merged.

@gopherbot gopherbot closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants