-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/windows: use SyscallN in mkwinsyscall #171
Conversation
This PR (HEAD: fffa8e2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995. Important tips:
|
Message from Alex Brainman: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
a929c3a
to
e1f3de4
Compare
This PR (HEAD: e1f3de4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995. Important tips:
|
e1f3de4
to
0cd54e8
Compare
Message from Mauri de Souza Meneguzzo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
This PR (HEAD: 0cd54e8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995. Important tips:
|
Message from Alex Brainman: Patch Set 4: Run-TryBot+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
0cd54e8
to
52272be
Compare
This PR (HEAD: 52272be) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995. Important tips:
|
The mkwinsyscall command has a hard limit of 15 on the number of syscall arguments. Windows has several system calls with more than 15 arguments, for example CreateFontPackage has 18 arguments. If the number of arguments is higher than 15 we use SyscallN. Updates golang/go#57914
52272be
to
1f1e96f
Compare
Message from Mauri de Souza Meneguzzo: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
This PR (HEAD: 1f1e96f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995. Important tips:
|
Message from Alex Brainman: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Alex Brainman: Patch Set 6: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Ian Lance Taylor: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Mauri de Souza Meneguzzo: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Mauri de Souza Meneguzzo: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Ian Lance Taylor: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Mauri de Souza Meneguzzo: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Ian Lance Taylor: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
Message from Ian Lance Taylor: Patch Set 6: Auto-Submit+1 Code-Review+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/518995. |
The mkwinsyscall command has a hard limit of 15 on the number of syscall arguments. Windows has several system calls with more than 15 arguments, for example CreateFontPackage has 18 arguments. If the number of arguments is higher than 15 we use SyscallN. Fixes golang/go#57914 Change-Id: I4205e779a960ae10c0778de7876154e0d7ec00a1 GitHub-Last-Rev: 1f1e96f GitHub-Pull-Request: #171 Reviewed-on: https://go-review.googlesource.com/c/sys/+/518995 Reviewed-by: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
This PR is being closed because golang.org/cl/518995 has been merged. |
The mkwinsyscall command has a hard limit of 15 on the
number of syscall arguments. Windows has several system
calls with more than 15 arguments, for example CreateFontPackage
has 18 arguments.
If the number of arguments is higher than 15 we use SyscallN.
Fixes golang/go#57914