Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unix: remove extra trailing newlines in zsyscall_openbsd_*.go #183

Closed
wants to merge 1 commit into from
Closed

unix: remove extra trailing newlines in zsyscall_openbsd_*.go #183

wants to merge 1 commit into from

Conversation

jrick
Copy link
Contributor

@jrick jrick commented Dec 20, 2023 •
edited
Loading

These newlines are written by mksyscall.go but should not appear in the final
generated files once the output is passed through gofmt. This is done by
mkall.sh but I had written a custom script just to generate these openbsd
zsyscall files in CL 468095.

Running the mksyscall.go output through gofmt fixes this issue.

Fixes golang/go#64820

@jrick
unix: remove extra trailing newlines in zsyscall_openbsd_*.go
514272b 
These newlines are written by mksyscall.go but should not appear in the final
generated files once the output is passed through gofmt.  This is done by
mkall.sh but I had written a custom script just to generate these openbsd
zsyscall files in CL 468095.

Running the mksyscall.go output through gofmt fixes this issue.

Fixes golang/go#64820
@gopherbot
Copy link

This PR (HEAD: 514272b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/551715.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Josh Rickmar:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jorropo:

Patch Set 2: Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2:

CV cannot start a Run for jorropo.pgm@gmail.com because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jorropo:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2:

CV cannot start a Run for jorropo.pgm@gmail.com because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jorropo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Josh Rickmar:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Than McIntosh:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-12-20T14:58:57Z","revision":"54ecbc5e886843ce3bf2b5429d0c46705924fe0e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Josh Rickmar:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Than McIntosh:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Than McIntosh:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Than McIntosh:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jorropo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Tobias Klauser:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Carlos Amedee:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 21, 2023
@jrick @tklauser
unix: remove extra trailing newlines in zsyscall_openbsd_*.go
f0c7190 
These newlines are written by mksyscall.go but should not appear in the final
generated files once the output is passed through gofmt.  This is done by
mkall.sh but I had written a custom script just to generate these openbsd
zsyscall files in CL 468095.

Running the mksyscall.go output through gofmt fixes this issue.

Fixes golang/go#64820

Change-Id: I1b1bf55145bd5a5208e091ded24a973f953c479f
GitHub-Last-Rev: 514272b
GitHub-Pull-Request: #183
Reviewed-on: https://go-review.googlesource.com/c/sys/+/551715
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Jorropo <jorropo.pgm@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/551715 has been merged.

@gopherbot gopherbot closed this Dec 21, 2023
@jrick jrick deleted the mksyscall_gofmt branch December 21, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/sys/unix: extra trailing newlines in zsyscall_openbsd_*.go files
2 participants
@jrick @gopherbot