New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: use uint32 for serial comm flags for consistency #189

Closed

twpayne wants to merge 1 commit into golang:master from twpayne:serial-comm-flags

Contributor

twpayne commented Apr 2, 2024 •

edited

Loading

This is a follow-up to https://go-review.googlesource.com/c/sys/+/572295
and specifically the comment
https://go-review.googlesource.com/c/sys/+/572295/comment/a00e1a2e_e3b01666/.

All other structs and methods us uint32 in golang.org/x/sys/windows
for flag bitmasks, so make the serial communication structs use uint32
to be consistent with the rest of the package.

As a side effect the DTR_CONTROL_* and RTS_CONTROL_* constants are
updated to reflect the positions of the bits in the 32-bit flags.


          x/sys/windows: use uint32 for serial comm flags

bc93d94

gopherbot commented Apr 2, 2024

This PR (HEAD: bc93d94) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/575635.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot commented Apr 2, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 2, 2024

Message from Tom Payne:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Alex Brainman:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-04T07:51:14Z","revision":"5654a0a3bddcce4ae2dcd708dd0918a44611d298"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Alex Brainman:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Alex Brainman:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Tom Payne:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          windows: use uint32 for serial comm flags for consistency

cabba82

This is a follow-up to https://go-review.googlesource.com/c/sys/+/572295
and specifically the comment
https://go-review.googlesource.com/c/sys/+/572295/comment/a00e1a2e_e3b01666/.

All other structs and methods us uint32 in golang.org/x/sys/windows
for flag bitmasks, so make the serial communication structs use uint32
to be consistent with the rest of the package.

As a side effect the DTR_CONTROL_* and RTS_CONTROL_* constants are
updated to reflect the positions of the bits in the 32-bit flags.

Change-Id: Ie19774a8ef5411d7df1e5b0d36806aa1d401fa86
GitHub-Last-Rev: bc93d94
GitHub-Pull-Request: #189
Reviewed-on: https://go-review.googlesource.com/c/sys/+/575635
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Than McIntosh <thanm@google.com>

gopherbot commented Apr 4, 2024

Message from Dmitri Shuralyov:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Dmitri Shuralyov:

Patch Set 2: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/575635.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

This PR is being closed because golang.org/cl/575635 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet