-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unix: fix MmapPtr test failing on OpenBSD #199
Conversation
OpenBSD apparently doesn't allow unmapping address space if part of the region is already unmapped. This tweaks the test so that munmapping twice no longer happens. Cq-Include-Trybots: luci.golang.try:gotip-openbsd-amd64
This PR (HEAD: 2535abd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/595095. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Go LUCI: Patch Set 1: Failed to compute tryjob requirement. Reason: builder "golang/try/gotip-openbsd-amd64" is included but not defined in the LUCI project Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-26T13:53:53Z","revision":"1a6d22bc65215dc6e68b218c5f4806a486e51f7f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Go LUCI: Patch Set 3: Failed to compute tryjob requirement. Reason: builder "golang/try/gotip-openbsd-amd64" is included but not defined in the LUCI project Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
Message from Ian Lance Taylor: Patch Set 4: Auto-Submit+1 TryBot-Bypass+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595095. |
OpenBSD apparently doesn't allow unmapping address space if part of the region is already unmapped. This tweaks the test so that munmapping twice no longer happens. Fixes golang/go#68181 Change-Id: I588255f5e10ec015dbb7188eac79cee6be570680 GitHub-Last-Rev: 2535abd GitHub-Pull-Request: #199 Cq-Include-Trybots: luci.golang.try:go1.22-openbsd-amd64 Reviewed-on: https://go-review.googlesource.com/c/sys/+/595095 TryBot-Bypass: Ian Lance Taylor <iant@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org>
This PR is being closed because golang.org/cl/595095 has been merged. |
OpenBSD apparently doesn't allow unmapping address space if part of the region is already unmapped.
This tweaks the test so that munmapping twice no longer happens.
Fixes golang/go#68181
Cq-Include-Trybots: luci.golang.try:go1.22-openbsd-amd64