-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/text/encoding/charmap: update UCM spec file URL prefix #48
Conversation
This PR (HEAD: 2a277c7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/546576. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Zachary Young: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Dominik Honnef: Patch Set 5: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Dominik Honnef: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Dmitri Shuralyov: Patch Set 5: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-15T16:43:58Z","revision":"a3456fee86ca6a0b3c3ea69fc5ff9b4bb57c5ab8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Dmitri Shuralyov: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
Message from Cherry Mui: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/546576. |
UCM spec files used by encoding/maketables.go moved from source.icu-project.org to github.com, and maketables is failing. The new repo is at https://github.com/unicode-org/icu-data/tree/main/charset/data/ucm. Changed all UCM mappings to use the "raw endpoint" prefix, https://raw.githubusercontent.com/unicode-org/icu-data/main/charset/data/ucm/…. Fixes golang/go#64504. Change-Id: Ib2ccf948ad79578efc4a0c356bb25325190dc333 GitHub-Last-Rev: 2a277c7 GitHub-Pull-Request: #48 Reviewed-on: https://go-review.googlesource.com/c/text/+/546576 Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dominik Honnef <dominik@honnef.co>
This PR is being closed because golang.org/cl/546576 has been merged. |
UCM spec files used by encoding/maketables.go moved from
source.icu-project.org to github.com, and maketables is failing.
The new repo is at
https://github.com/unicode-org/icu-data/tree/main/charset/data/ucm.
Changed all UCM mappings to use the "raw endpoint" prefix,
https://raw.githubusercontent.com/unicode-org/icu-data/main/charset/data/ucm/….
Fixes golang/go#64504.