Skip to content

Commit

Permalink
gopls/doc: update tests that fail on Kokoro to run at Go 1.21+
Browse files Browse the repository at this point in the history
TestGenerated and TestLicenses both fail on Kokoro, for unknown reasons,
and only need to be run on one Go version.

Change-Id: I49950c7b6f34747ee94960f5cc0860cd348b391e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/522235
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
  • Loading branch information
findleyr committed Aug 23, 2023
1 parent 7b7b9a1 commit 0a044c0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions gopls/doc/generate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import (

func TestGenerated(t *testing.T) {
testenv.NeedsGoPackages(t)
// This test fails on 1.18 Kokoro for unknown reasons; in any case, it
// suffices to run this test on any builder.
testenv.NeedsGo1Point(t, 19)
// This test fails on Kokoro, for unknown reasons, so must be run only on TryBots.
// In any case, it suffices to run this test on any builder.
testenv.NeedsGo1Point(t, 21)

testenv.NeedsLocalXTools(t)

Expand Down
2 changes: 1 addition & 1 deletion gopls/internal/hooks/licenses_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func TestLicenses(t *testing.T) {
// License text differs for older Go versions because staticcheck or gofumpt
// isn't supported for those versions, and this fails for unknown, unrelated
// reasons on Kokoro legacy CI.
testenv.NeedsGo1Point(t, 19)
testenv.NeedsGo1Point(t, 21)

if runtime.GOOS != "linux" && runtime.GOOS != "darwin" {
t.Skip("generating licenses only works on Unixes")
Expand Down

0 comments on commit 0a044c0

Please sign in to comment.