[gopls-release-branch.0.4] internal/lsp: check if analysis enabled in…

… convenience fixes

Change-Id: I49c7808ee07340cea0381f324b1fb113ec405213
Reviewed-on: https://go-review.googlesource.com/c/tools/+/241519
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 7370b03)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/241522

internal/lsp/code_action.go

@@ -349,6 +349,9 @@ func findSourceError(ctx context.Context, snapshot source.Snapshot, pkgID string
 func convenienceFixes(ctx context.Context, snapshot source.Snapshot, ph source.PackageHandle, uri span.URI, rng protocol.Range) ([]protocol.CodeAction, error) {
 	var analyzers []*analysis.Analyzer
 	for _, a := range snapshot.View().Options().ConvenienceAnalyzers {
+		if !a.Enabled(snapshot) {
+			continue
+		}
 		analyzers = append(analyzers, a.Analyzer)
 	}
 	diagnostics, err := snapshot.Analyze(ctx, ph.ID(), analyzers...)

internal/lsp/tests/util.go

@@ -516,6 +516,11 @@ func EnableAllAnalyzers(snapshot source.Snapshot, opts *source.Options) {
 			opts.UserEnabledAnalyses[a.Analyzer.Name] = true
 		}
 	}
+	for _, a := range opts.ConvenienceAnalyzers {
+		if !a.Enabled(snapshot) {
+			opts.UserEnabledAnalyses[a.Analyzer.Name] = true
+		}
+	}
 }
 
 func Diff(want, got string) string {