Skip to content

Commit

Permalink
internal/gcimporter: renable tests of issue50259.go
Browse files Browse the repository at this point in the history
Now that the compiler support for gotypesalias=1 is
fixed (by CL 574737), we can reenable these tests.

Updates golang/go#66550
Updates golang/go#65294

Change-Id: I70b187c561d2eeb3f7a4cc078107b7bcce5ced01
Reviewed-on: https://go-review.googlesource.com/c/tools/+/576139
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Tim King <taking@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
  • Loading branch information
adonovan authored and gopherbot committed Apr 4, 2024
1 parent f1d5252 commit 6590f47
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion internal/gcimporter/gcimporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ func TestImportTypeparamTests(t *testing.T) {
"nested.go": "fails to compile", // TODO(rfindley): investigate this.
"issue47631.go": "can not handle local type declarations",
"issue55101.go": "fails to compile",
"issue50259.go": "compiler crashes if GODEBUG=gotypesalias=1", // TODO(adonovan): delete when #66550 is fixed.
}
}

Expand Down
6 changes: 0 additions & 6 deletions internal/gcimporter/iexport_go118_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,6 @@ func TestImportTypeparamTests(t *testing.T) {
t.Fatal(err)
}

// TODO(adonovan): delete when #66550 is fixed.
if strings.Contains(os.Getenv("GODEBUG"), "gotypesalias=1") &&
entry.Name() == "issue50259.go" {
t.Skip("Skipping test of defined<->alias cycle under gotypesaliases=1 (#66550)")
}

if !bytes.HasPrefix(src, []byte("// run")) && !bytes.HasPrefix(src, []byte("// compile")) {
// We're bypassing the logic of run.go here, so be conservative about
// the files we consider in an attempt to make this test more robust to
Expand Down

0 comments on commit 6590f47

Please sign in to comment.