Skip to content

Commit

Permalink
gopls/internal/settings: drop experimental hoverKind=Structured
Browse files Browse the repository at this point in the history
We thought it was used by govim, but apparently not.

Fixes golang/go#70233

Change-Id: Iacd85833dba91e870accf038e1c69a01e42fca1f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/635226
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
  • Loading branch information
adonovan committed Dec 13, 2024
1 parent 7bfb27f commit 8127761
Show file tree
Hide file tree
Showing 6 changed files with 111 additions and 123 deletions.
2 changes: 2 additions & 0 deletions gopls/doc/release/v0.18.0.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Configuration Changes

- The experimental `hoverKind=Structured` setting is no longer supported.

# New features

## "Implementations" supports generics
Expand Down
6 changes: 1 addition & 5 deletions gopls/doc/settings.md
Original file line number Diff line number Diff line change
Expand Up @@ -399,17 +399,13 @@ Default: `true`.
### `hoverKind enum`

hoverKind controls the information that appears in the hover text.
SingleLine and Structured are intended for use only by authors of editor plugins.
SingleLine is intended for use only by authors of editor plugins.

Must be one of:

* `"FullDocumentation"`
* `"NoDocumentation"`
* `"SingleLine"`
* `"Structured"` is an experimental setting that returns a structured hover format.
This format separates the signature from the documentation, so that the client
can do more manipulation of these fields.\
This should only be used by clients that support this behavior.
* `"SynopsisDocumentation"`

Default: `"FullDocumentation"`.
Expand Down
6 changes: 1 addition & 5 deletions gopls/internal/doc/api.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
{
"Name": "hoverKind",
"Type": "enum",
"Doc": "hoverKind controls the information that appears in the hover text.\nSingleLine and Structured are intended for use only by authors of editor plugins.\n",
"Doc": "hoverKind controls the information that appears in the hover text.\nSingleLine is intended for use only by authors of editor plugins.\n",
"EnumKeys": {
"ValueType": "",
"Keys": null
Expand All @@ -113,10 +113,6 @@
"Value": "\"SingleLine\"",
"Doc": ""
},
{
"Value": "\"Structured\"",
"Doc": "`\"Structured\"` is an experimental setting that returns a structured hover format.\nThis format separates the signature from the documentation, so that the client\ncan do more manipulation of these fields.\n\nThis should only be used by clients that support this behavior.\n"
},
{
"Value": "\"SynopsisDocumentation\"",
"Doc": ""
Expand Down
Loading

0 comments on commit 8127761

Please sign in to comment.