Skip to content

Commit

Permalink
gopls/internal/test/marker: skip on solaris-amd64-oraclerel
Browse files Browse the repository at this point in the history
As with the darwin builders, this builder is too slow for this test. Not
investigated.

Fixes golang/go#64473

Change-Id: Ice9b3f25ddb70327dd8d259063bf351db167eff5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/555715
Auto-Submit: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
  • Loading branch information
findleyr committed Jan 12, 2024
1 parent dbc9d3e commit 9164f2a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions gopls/internal/test/marker/marker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,11 @@ func TestMain(m *testing.M) {
// - The old tests lacked documentation, and often had failures that were hard
// to understand. By starting from scratch, we can revisit these aspects.
func Test(t *testing.T) {
if testing.Short() && strings.HasPrefix(os.Getenv("GO_BUILDER_NAME"), "darwin-") {
t.Skip("golang/go#64473: skipping with -short: this test is too slow on darwin builders")
if testing.Short() {
builder := os.Getenv("GO_BUILDER_NAME")
if strings.HasPrefix(builder, "darwin-") || builder == "solaris-amd64-oraclerel" {
t.Skip("golang/go#64473: skipping with -short: this test is too slow on darwin and solaris builders")
}
}
// The marker tests must be able to run go/packages.Load.
testenv.NeedsGoPackages(t)
Expand Down

0 comments on commit 9164f2a

Please sign in to comment.