Skip to content

Commit

Permalink
go/internal/gcimporter: skip TestIExportData_stdlib on go1.18
Browse files Browse the repository at this point in the history
This test will fail on Go 1.18 once standard library changes are
introduced that use generics. Skip it until iexport.go has been updated
to support generics.

Updates golang/go#48392

Change-Id: I0f779689daaf2bc3127affff633c883ed9d7289b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/349954
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
  • Loading branch information
findleyr committed Sep 14, 2021
1 parent cd7c003 commit 9207707
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions go/internal/gcimporter/iexport_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"golang.org/x/tools/go/buildutil"
"golang.org/x/tools/go/internal/gcimporter"
"golang.org/x/tools/go/loader"
"golang.org/x/tools/internal/testenv"
)

func readExportFile(filename string) ([]byte, error) {
Expand Down Expand Up @@ -63,6 +64,7 @@ func iexport(fset *token.FileSet, pkg *types.Package) ([]byte, error) {
}

func TestIExportData_stdlib(t *testing.T) {
testenv.SkipAfterGo1Point(t, 17)
if runtime.Compiler == "gccgo" {
t.Skip("gccgo standard library is inaccessible")
}
Expand Down

0 comments on commit 9207707

Please sign in to comment.