Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[gopls-release-branch.0.15] gopls/internal/server: fix crash in Signa…
…tureHelp Fix a crash when Snapshot.fileOf fails, due to e.g. context cancellation. The defer of release should only occur after the error is checked. Unfortunately, this is very hard to test since it likely occurs only due to races. This is our first bug found completely via automated crash reporting. Fixes golang/go#66090 Change-Id: I7c22b5c2d1a0115718cd4bf2b84c31cc38a891ec Reviewed-on: https://go-review.googlesource.com/c/tools/+/570675 Auto-Submit: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit f89da53) Reviewed-on: https://go-review.googlesource.com/c/tools/+/570596
- Loading branch information