-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
go/types/objectpath: memoize scope lookup in objectpath.Encoder
Profiling revealed that scope lookup itself was costly, so memoize the objects themselves, not just their names. Also update BenchmarkCompletionFollowingEdit to allow it to be run on multiple repos, and add a test case for kubernetes. For golang/go#53992 Change-Id: I17b1f39d8c356e8628610a544306686573a813a7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/502976 gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> TryBot-Bypass: Robert Findley <rfindley@google.com>
- Loading branch information
Showing
2 changed files
with
90 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters