-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[gopls-release-branch.0.16] gopls/internal/settings: move CodeLensSou…
…rce from protocol This enum is properly a setting, not a protocol feature. The .md and api.json generator script assumes that all enums are in the settings package, and consequently emitted incorrect names for this type. Generator changes in detail: - remove the package.Load of both "settings" and "protocol", reverting part of an early change. - remove loadAPI special case for "codelenses" not being an enum-keyed map, as it is one. (As a consequence, the enum values appear in api.json in alphabetical, not declaration, order. Also, the title portion of the codelend doc string is no longer discarded.) - add lots of missing commentary. This may seem like a large change at the 11th hour, but note: - the only change to the production code is a renaming; - the effects of the generator changes are entirely confined to settings.md and api.json. Fixes golang/go#68057 Change-Id: I097f0a9b2e34b8f9a3438112b55efb2081b4acb2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/593615 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit 1cd1a4f08f940bc68597469ffb33630f33ef104f) Reviewed-on: https://go-review.googlesource.com/c/tools/+/593676 Auto-Submit: Alan Donovan <adonovan@google.com>
- Loading branch information
Showing
11 changed files
with
210 additions
and
220 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.