Skip to content

Commit

Permalink
gopls/internal/test/marker: update skip comment for addgowork.txt
Browse files Browse the repository at this point in the history
The orphaned file and critical error logic has been rewritten, and we no
longer diagnose broken workspaces in this way, because they are no
longer broken due to zero-config gopls.

Fixes golang/go#61006

Change-Id: I7e532c1ecf11b5151ff03103bb19806caaeec565
Reviewed-on: https://go-review.googlesource.com/c/tools/+/555755
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
  • Loading branch information
findleyr committed Jan 17, 2024
1 parent c0db45f commit d2200d1
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions gopls/internal/test/marker/testdata/diagnostics/addgowork.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@ Quick-fixes change files on disk, so are tested by integration tests.
TODO(rfindley): improve the "cannot find package" import errors.

-- skip --
Skipping due to go.dev/issue/60584#issuecomment-1622238115.
There appears to be a real race in the critical error logic causing this test
to flake with high frequency.
These diagnostics are no longer produced, because in golang/go#57979
(zero-config gopls) we made gopls function independent of a go.work file.
Preserving this test as we may want to re-enable the code actions go manage
a go.work file.

Note that in go.dev/issue/60584#issuecomment-1622238115, this test was flaky.
However, critical error logic has since been rewritten.

-- a/go.mod --
module mod.com/a
Expand Down

0 comments on commit d2200d1

Please sign in to comment.