-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/gcimporter: remove bug report on objectpath failure
As reported in golang/go#61674, there are certain cases involving instantiated fields that simply can't be encoded using objectpaths. Therefore, the workaround is fundamentally insufficient, and should probably be removed or made irrelevant (golang/go#61674). In the meantime, update commentary and remove the bug report. Update the gopls regression test for this behavior to exercise the objectpath failure. While at it, ensure that the marker regtests panic on bugs, like all other regtests. This ran into an existing imprecise bug report, which is amended. Updates golang/go#61674 Change-Id: I0eaea00d46cec88ac4c20cebdde805a7db3a33ad Reviewed-on: https://go-review.googlesource.com/c/tools/+/514575 gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
- Loading branch information
Showing
5 changed files
with
36 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters