Skip to content

Commit

Permalink
gopls/internal/regtest/marker: clean up some random packages
Browse files Browse the repository at this point in the history
%percent and noparse are merged into a strangefiles.txt suite, with the
caveat that I have no idea why they existed.

We already had a placeholder port of the (disabled) nested_complit test.

For golang/go#54845

Change-Id: I81fd6a9c2403a9e10380b890495a51dcf243d2d9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/541127
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
  • Loading branch information
findleyr committed Nov 9, 2023
1 parent bbf8bf8 commit e3f6798
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 16 deletions.
1 change: 0 additions & 1 deletion gopls/internal/lsp/testdata/%percent/perc%ent.go

This file was deleted.

15 changes: 0 additions & 15 deletions gopls/internal/lsp/testdata/nested_complit/nested_complit.go.in

This file was deleted.

Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
This test checks diagnostics on files that are strange for one reason or
another.

Note(rfindley): ported from the old marker tests. I'm not sure why these were
written originally.

-ignore_extra_diags is required because the marker framework fails for
noparse.go, and we therefore can't match the EOF error.

-- flags --
-ignore_extra_diags

-- go.mod --
module golang.org/lsptests

go 1.18
-- %percent/perc%ent.go --
package percent //@diag("percent", re"not included in your workspace")

-- noparse/noparse.go --

0 comments on commit e3f6798

Please sign in to comment.