internal/jsonrpc2: fix jsonrpc result no pending[id] blocking #155

a-wing · 2019-09-11T11:06:49Z

fix jsonrpc result no pending[id] always waits for a response

… a response

googlebot · 2019-09-11T11:06:56Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

a-wing · 2019-09-11T11:12:50Z

@googlebot I signed it!

googlebot · 2019-09-11T11:12:52Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gopherbot · 2019-09-11T11:14:52Z

This PR (HEAD: 87b3d0a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/194640 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-11T11:16:52Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-11T15:22:55Z

Message from Brad Fitzpatrick:

Patch Set 1:

Please add a test.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-12T03:42:27Z

Message from Ian Cottrell:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-12T06:04:51Z

Message from metal a-wing:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-16T13:12:59Z

This PR (HEAD: edbd8c9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/194640 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-16T13:23:02Z

Message from metal a-wing:

Patch Set 2:

Patch Set 1:

Please add a test.

Test added

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

Ref golang/tools#155

gopherbot · 2019-10-29T03:45:54Z

Message from Rebecca Stambler:

Patch Set 2: Run-TryBot+1

Ian, what do you think here?

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T03:45:55Z

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2925fb9a

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T03:48:13Z

Message from Gobot Gobot:

Patch Set 2:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/97592b3c/freebsd-amd64-12_0_09a02495.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T03:51:59Z

Message from Gobot Gobot:

Patch Set 2: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:08:22Z

Message from Rebecca Stambler:

Patch Set 3: Patch Set 2 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:08:23Z

Message from Rebecca Stambler:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:08:24Z

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=68093fb3

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:11:35Z

Message from Gobot Gobot:

Patch Set 3:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/ba0bab7b/linux-amd64_477344a6.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:15:48Z

Message from Gobot Gobot:

Patch Set 3: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:54:49Z

Message from Rebecca Stambler:

Patch Set 3:

TryBot failures are unrelated - caused by golang/go#35226.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-30T22:24:41Z

Message from Rebecca Stambler:

Patch Set 4: Patch Set 3 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-30T22:24:42Z

Message from Rebecca Stambler:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-30T22:24:43Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=97388307

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-30T22:31:39Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-21T22:23:53Z

Message from Ian Cottrell:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/194640.
After addressing review feedback, remember to publish your drafts!

maxhawkins · 2020-01-10T18:42:15Z

I also ran into this bug.

If you cancel the context given to Call server-side and then the client sends a reply anyway it deadlocks the server.

@ianthehat

maxhawkins · 2020-03-05T00:15:51Z

I believe this issue is fixed by 88be013

gopherbot · 2020-08-08T21:43:19Z

This PR is being closed because golang.org/cl/194640 has been abandoned.

See Ian's comment

internal/jsonrpc2: fix jsonrpc result no pending[id] always waits for…

87b3d0a

… a response

googlebot added the cla: no label Sep 11, 2019

googlebot added cla: yes and removed cla: no labels Sep 11, 2019

internal/jsonrpc2_test: add jsonrpc result no pending[id]

edbd8c9

a-wing added a commit to sb-im/jsonrpc-lite that referenced this pull request Sep 17, 2019

Fix jsonrpc result no pending[id]

6cb3b4f

Ref golang/tools#155

gopherbot force-pushed the master branch from 9cd7e18 to b917058 Compare October 4, 2019 02:21

gopherbot closed this Aug 8, 2020

bsponge added a commit to bsponge/tools that referenced this pull request Sep 30, 2023

* simplifications (comments golang#150, golang#155)

5b9bb80

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal/jsonrpc2: fix jsonrpc result no pending[id] blocking #155

internal/jsonrpc2: fix jsonrpc result no pending[id] blocking #155

a-wing commented Sep 11, 2019

googlebot commented Sep 11, 2019

a-wing commented Sep 11, 2019

googlebot commented Sep 11, 2019

gopherbot commented Sep 11, 2019

gopherbot commented Sep 11, 2019

gopherbot commented Sep 11, 2019

gopherbot commented Sep 12, 2019

gopherbot commented Sep 12, 2019

gopherbot commented Sep 16, 2019

gopherbot commented Sep 16, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Nov 21, 2019

maxhawkins commented Jan 10, 2020

maxhawkins commented Mar 5, 2020

gopherbot commented Aug 8, 2020

internal/jsonrpc2: fix jsonrpc result no pending[id] blocking #155

internal/jsonrpc2: fix jsonrpc result no pending[id] blocking #155

Conversation

a-wing commented Sep 11, 2019

googlebot commented Sep 11, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

a-wing commented Sep 11, 2019

googlebot commented Sep 11, 2019

gopherbot commented Sep 11, 2019

gopherbot commented Sep 11, 2019

gopherbot commented Sep 11, 2019

gopherbot commented Sep 12, 2019

gopherbot commented Sep 12, 2019

gopherbot commented Sep 16, 2019

gopherbot commented Sep 16, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Nov 21, 2019

maxhawkins commented Jan 10, 2020

maxhawkins commented Mar 5, 2020

gopherbot commented Aug 8, 2020