-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls/internal/lsp: add code action for conversion between raw and interpreted string #460
gopls/internal/lsp: add code action for conversion between raw and interpreted string #460
Conversation
This PR (HEAD: e27da45) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR (HEAD: f31293b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
Message from Kun Yuan: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Alan Donovan: Patch Set 2: (8 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Alan Donovan: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Kun Yuan: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR (HEAD: f45f09d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
Message from Kun Yuan: Patch Set 2: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Alan Donovan: Patch Set 3: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Kun Yuan: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Alan Donovan: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Kun Yuan: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR (HEAD: 767d098) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
This PR (HEAD: 98fd6b4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Kun Yuan: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR (HEAD: 5de9228) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
Message from Alan Donovan: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR (HEAD: ca2e59d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
Message from Kun Yuan: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Kun Yuan: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Alan Donovan: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR (HEAD: c38a22b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
…terpreted string The code action for conversion will return when the range is string. When string is raw string, the action is convert back quote string to double quote string. Otherwise, the action is convert double quote string to back quote Fixes golang/go#51200
Message from Alan Donovan: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR (HEAD: 19df352) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/542235. Important tips:
|
Message from Kun Yuan: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Alan Donovan: Patch Set 9: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-17T16:38:32Z","revision":"f5dc3c26c9353dd8d3a1e2946859699bf1c32d8d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
…terpreted string The code action for conversion will return when the range is string. When string is raw string, the action is convert back quote string to double quote string. Otherwise, the action is convert double quote string to back quote Fixes golang/go#51200 Change-Id: Ib4b99ed4fa80277f668c2e534e0aa3041af362e0 GitHub-Last-Rev: 19df352 GitHub-Pull-Request: #460 Reviewed-on: https://go-review.googlesource.com/c/tools/+/542235 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
Message from Alan Donovan: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Go LUCI: Patch Set 9: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/542235. |
This PR is being closed because golang.org/cl/542235 has been merged. |
The code action for conversion will return when the range is string.
When string is raw string, the action is convert back quote string to double quote string.
Otherwise, the action is convert double quote string to back quote
Fixes golang/go#51200