-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls: add non nil if check around function result highlight #480
gopls: add non nil if check around function result highlight #480
Conversation
This PR (HEAD: 8fc8b3d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/567275. Important tips:
|
52959dd
to
cc3cc9d
Compare
The result of funcType will be nil, if a function does not return any values. This caused an SIGSEGV before. Fixes golang/go#65952
cc3cc9d
to
74182b2
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
This PR (HEAD: 74182b2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/567275. Important tips:
|
Message from Patrick: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: Code-Review+1 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-27T10:48:38Z","revision":"896f28e4e013577bc9ff03db02999232cab8b7d7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Patrick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
25359d3
to
74182b2
Compare
Message from qiulaidongfeng: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Patrick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Patrick: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Robert Findley: Patch Set 3: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-27T14:58:00Z","revision":"5085c1f38ee300dbf1cac4f67da9f70b2c9b80aa"} Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Robert Findley: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
The result of funcType will be nil, if a function does not return any values. This caused an SIGSEGV before. Fixes golang/go#65952 Change-Id: Ibf4ac3070744f42033504220f05b35a78c97d992 GitHub-Last-Rev: 74182b2 GitHub-Pull-Request: #480 Reviewed-on: https://go-review.googlesource.com/c/tools/+/567275 Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Message from Hyang-Ah Hana Kim: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/567275. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-27T16:06:47Z","revision":"dd6df94d8e3a3a6cef2fcb4b860b36dc01f581be"} Please don’t reply on this GitHub thread. Visit golang.org/cl/567415. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/567415. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/567415. |
Message from Alan Donovan: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/567415. |
…on result highlight The result of funcType will be nil, if a function does not return any values. This caused an SIGSEGV before. Fixes golang/go#65952 Change-Id: Ibf4ac3070744f42033504220f05b35a78c97d992 GitHub-Last-Rev: 74182b2 GitHub-Pull-Request: #480 Reviewed-on: https://go-review.googlesource.com/c/tools/+/567275 Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit c1f340a) Reviewed-on: https://go-review.googlesource.com/c/tools/+/567415 Reviewed-by: Alan Donovan <adonovan@google.com>
This PR is being closed because golang.org/cl/567415 has been merged. |
The result of funcType will be nil, if a function does not return any
values. This caused an SIGSEGV before.
Fixes golang/go#65952