Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: simplify generated launch.json #131

Closed
4 tasks done
ramya-rao-a opened this issue May 28, 2020 · 4 comments
Closed
4 tasks done

debug: simplify generated launch.json #131

ramya-rao-a opened this issue May 28, 2020 · 4 comments
Assignees
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 28, 2020

From microsoft/vscode-go#2120 by @isidorn:

The launch.json that GO generates is attached at the end. This is cool and simple. However we can still do the following

  • Go needs to activate on onDebugInitialConfigurations
  • Consider to use quickPick in DebugConfigurationProvider to ask the user if he would like to launch file, launch package, connect to server, launch test package, launch test function and based on that create a launch configuration.
  • Remove default fields which are not necessery like env, args. Both from the configurationSnippets and from the intial configurations
  • What is the biggest pain point for go debugging setup, could we somehow help there with dynamicly providing debug configuratons or resolving them
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch",
            "type": "go",
            "request": "launch",
            "mode": "auto",
            "program": "${fileDirname}",
            "env": {},
            "args": []
        }
    ]
}

Related upstream issue in VS Code: microsoft/vscode#62851

For prior discussion on this issue, please see microsoft/vscode-go#2120

@stamblerre stamblerre added the Debug Issues related to the debugging functionality of the extension. label May 29, 2020
@stamblerre stamblerre changed the title Simplify generated launch.json debug: simplify generated launch.json Jun 3, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/267899 mentions this issue: package.json: activate extension onDebugInitialConfigurations

@suzmue
Copy link
Contributor

suzmue commented Nov 5, 2020

Go needs to activate on onDebugInitialConfigurations

I have sent a change to activate the extension onDebugInitialConfigurations.

Consider to use quickPick in DebugConfigurationProvider to ask the user if he would like to launch file, launch package, connect to server, launch test package, launch test function and based on that create a launch configuration

This seems like a good idea! Will leave this issue open to track this.

Remove default fields which are not necessary like env, args. Both from the configurationSnippets and from the intial configurations

Ramya addressed this in the linked issue. These are there for discoverability purposes and we plan to keep them there at this time.

What is the biggest pain point for go debugging setup, could we somehow help there with dynamically providing debug configurations or resolving them

@lggomez mentioned in the linked issue that the "inconsistency between the debug test codelens and the debug viewlet launcher" was one of the main pain points. This issue is now covered by #855

gopherbot pushed a commit that referenced this issue Nov 6, 2020
The extension should be activated before provideDebugConfigurations
method is called.

Updates #131

Change-Id: I06a3cf18da63c9bdae01d7ce8d177dfa872e4f21
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/267899
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@hyangah hyangah added this to the v0.19.0 milestone Nov 17, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/271237 mentions this issue: src/goDebugConfiguration.ts: offer quick pick menu for creating launch.json

@hyangah hyangah modified the milestones: v0.19.0, v0.20.0 Nov 25, 2020
gopherbot pushed a commit that referenced this issue Dec 9, 2020
…h.json

When a user chooses 'create launch.json' from the vscode UI, we can offer them
different options to fill in their initial launch.json file. We use a quickpick
menu to provide default launch configurations (very similar to the snippets
for debug configuration) and start the initial launch.json with the
chosen configuration.

Updates #131

Change-Id: I804ed30a771f13db478b43dd632671f0cbbaed1c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/271237
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@hyangah
Copy link
Contributor

hyangah commented Dec 21, 2020

@suzmue It looks like cl/271237 completes all the remaining tasks. Is it ok to close this?

@hyangah hyangah modified the milestones: v0.21.0, v0.20.0 Dec 21, 2020
@suzmue suzmue closed this as completed Jan 5, 2021
@golang golang locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

5 participants