-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: simplify generated launch.json #131
Comments
Change https://golang.org/cl/267899 mentions this issue: |
I have sent a change to activate the extension onDebugInitialConfigurations.
This seems like a good idea! Will leave this issue open to track this.
Ramya addressed this in the linked issue. These are there for discoverability purposes and we plan to keep them there at this time.
@lggomez mentioned in the linked issue that the "inconsistency between the debug test codelens and the debug viewlet launcher" was one of the main pain points. This issue is now covered by #855 |
The extension should be activated before provideDebugConfigurations method is called. Updates #131 Change-Id: I06a3cf18da63c9bdae01d7ce8d177dfa872e4f21 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/267899 Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Change https://golang.org/cl/271237 mentions this issue: |
…h.json When a user chooses 'create launch.json' from the vscode UI, we can offer them different options to fill in their initial launch.json file. We use a quickpick menu to provide default launch configurations (very similar to the snippets for debug configuration) and start the initial launch.json with the chosen configuration. Updates #131 Change-Id: I804ed30a771f13db478b43dd632671f0cbbaed1c Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/271237 Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@suzmue It looks like cl/271237 completes all the remaining tasks. Is it ok to close this? |
From microsoft/vscode-go#2120 by @isidorn:
The
launch.json
that GO generates is attached at the end. This is cool and simple. However we can still do the followingonDebugInitialConfigurations
quickPick
inDebugConfigurationProvider
to ask the user if he would like to launch file, launch package, connect to server, launch test package, launch test function and based on that create a launch configuration.env
,args
. Both from the configurationSnippets and from the intial configurationsRelated upstream issue in VS Code: microsoft/vscode#62851
For prior discussion on this issue, please see microsoft/vscode-go#2120
The text was updated successfully, but these errors were encountered: