Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testExplorer: fix tests #1788

Closed
hyangah opened this issue Sep 20, 2021 · 4 comments
Closed

testExplorer: fix tests #1788

hyangah opened this issue Sep 20, 2021 · 4 comments
Assignees
@hyangah
Labels
FrozenDueToAge
Milestone
vscode-go/backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 20, 2021

Following tests are still failing with workspace.fs.dirs.get is not a function or its return value is not iterable errors on windows
at 171cc61

> ``` 12) Go Test Explorer Document opened In workspace: TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54) at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13) at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5) at newExplorer (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:32:20) at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:96:44 at Generator.next () at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:8:71 at new Promise () at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:4:12) at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:94:30) at processImmediate (internal/timers.js:461:21)

  1. Go Test Explorer
    Document opened
    Outside workspace:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at newExplorer (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:32:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:96:44
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:94:30)
    at processImmediate (internal/timers.js:461:21)

  2. Go Test Explorer
    Document edited
    Add test:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at newExplorer (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:32:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:154:44
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:152:30)
    at processImmediate (internal/timers.js:461:21)

  3. Go Test Explorer
    Document edited
    Remove test:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at newExplorer (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:32:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:154:44
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:152:30)
    at processImmediate (internal/timers.js:461:21)

  4. Go Test Explorer
    settings
    packageDisplayMode
    "before each" hook for "flat":
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at newExplorer (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:32:20)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:205:34)
    at processImmediate (internal/timers.js:461:21)

  5. Go Test Explorer
    settings
    alwaysRunBenchmarks
    "before each" hook for "false":
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at newExplorer (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:32:20)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:252:28)
    at processImmediate (internal/timers.js:461:21)

  6. Go Test Explorer
    settings
    showDynamicSubtestsInEditor
    "before each" hook for "false":
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at newExplorer (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:32:20)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.explore.test.js:297:28)
    at processImmediate (internal/timers.js:461:21)

  7. Go Test Resolver
    Root
    Basic module:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  8. Go Test Resolver
    Root
    Basic workspace:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  9. Go Test Resolver
    Root
    Module and workspace:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  10. Go Test Resolver
    Root
    Module in workspace:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  11. Go Test Resolver
    Module
    Empty:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  12. Go Test Resolver
    Module
    Root package:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  13. Go Test Resolver
    Module
    Sub packages:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  14. Go Test Resolver
    Module
    Nested packages:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  15. Go Test Resolver
    Package
    Empty:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  16. Go Test Resolver
    Package
    Flat:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  17. Go Test Resolver
    Package
    Sub package:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  18. Go Test Resolver
    File
    Empty:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

  19. Go Test Resolver
    File
    One of each:
    TypeError: workspace.fs.dirs.get is not a function or its return value is not iterable
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:34:54)
    at walk (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:45:13)
    at Object.populateModulePathCache (d:\a\vscode-go\vscode-go\out\test\integration\goTest.utils.js:52:5)
    at setup (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:26:20)
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:191:48
    at Generator.next ()
    at d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:8:71
    at new Promise ()
    at __awaiter (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:4:12)
    at Context. (d:\a\vscode-go\vscode-go\out\test\integration\goTest.resolve.test.js:189:31)
    at processImmediate (internal/timers.js:461:21)

</details>
@hyangah hyangah added this to the On Deck milestone Sep 20, 2021
hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 19, 2022
@hyangah
test/integration: skip tests broken on windows
a0e1425 
Added affectedByIssue832 to clearly indicate the tests
that need to be fixed.

For golang#832
For golang#1788

FORCE RUN CI

Change-Id: Ied7dc9726b33f092ae93a1f11952f97fd1433337
hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 19, 2022
@hyangah
test/integration: skip tests broken on windows
ca8e46c 
Added affectedByIssue832 to clearly indicate the tests
that need to be fixed.

For golang#832
For golang#1788

FORCE RUN CI

Change-Id: Ied7dc9726b33f092ae93a1f11952f97fd1433337
hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 19, 2022
@hyangah
test/integration: skip tests broken on windows
6921fd1 
Added affectedByIssue832 to clearly indicate the tests
that need to be fixed.

For golang#832
For golang#1788

FORCE RUN CI

Change-Id: Ied7dc9726b33f092ae93a1f11952f97fd1433337
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/418356 mentions this issue: test/integration: skip tests broken on windows

hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 20, 2022
@hyangah
test/integration: skip tests broken on windows
5dd2f19 
Added affectedByIssue832 to clearly indicate the tests
that need to be fixed.

For golang#832
For golang#1788

Change-Id: Ied7dc9726b33f092ae93a1f11952f97fd1433337
gopherbot pushed a commit that referenced this issue Jul 20, 2022
@hyangah
test/integration: skip tests broken on windows
9bb57d8 
Added affectedByIssue832 to clearly indicate the tests
that need to be fixed.

For #832
For #1788

Change-Id: Ied7dc9726b33f092ae93a1f11952f97fd1433337
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/418356
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 21, 2022
@hyangah
test/integration/goTest: fix Document opened test
8a80a41 
And reenable the test.

The test was broken due to a bug in composing the file Uris for
files in a directory from the directory Uri. path.join uses the
platform specific separator (\ on windows). To ensure the correct
encoding, convert the directory Uri to its fsPath, construct the
file path of the file, and convert the file path to Uri.

For golang#832
For golang#1788

Change-Id: I3dfc44e04f1683b1b862b339b7257b432c3f2241
hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 21, 2022
@hyangah
test/integration/goTest: fix Document opened test
cd4d606 
And reenable the test.

The test was broken due to a bug in composing the file Uris for
files in a directory from the directory Uri. path.join uses the
platform specific separator (\ on windows). To ensure the correct
encoding, convert the directory Uri to its fsPath, construct the
file path of the file, and convert the file path to Uri.

For golang#832
For golang#1788

Change-Id: I3dfc44e04f1683b1b862b339b7257b432c3f2241
hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 21, 2022
@hyangah
test/integration/goTest: fix populateModulePathCache
a6ca693 
And reenable affected tests.

The tests were broken due to a bug in composing the file Uris for
files in a directory from the directory Uri. path.join uses the
platform specific separator (\ on windows). To ensure the correct
encoding, convert the directory Uri to its fsPath, construct the
file path of the file, and convert the file path to Uri.

For golang#832
For golang#1788

Change-Id: I3dfc44e04f1683b1b862b339b7257b432c3f2241
hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 21, 2022
@hyangah
src/goTest/resolve: fix nested packageDisplayMode handling on win32
d247c4b 
To use path module, use Uri.fsPath, not Uri.path.

For golang#832
For golang#1788

Change-Id: Ic07e19f2f83cc4b05b3be750de4be7bcdb6e6656
@hyangah hyangah self-assigned this Jul 21, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/418547 mentions this issue: src/goTest/resolve: fix nested packageDisplayMode handling on win32

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/418545 mentions this issue: test/integration/goTest: fix populateModulePathCache

hyangah added a commit to hyangah/vscode-go that referenced this issue Jul 21, 2022
@hyangah
src/goTest/resolve: fix nested packageDisplayMode handling on win32
55f5d43 
To use path module, use Uri.fsPath, not Uri.path.

For golang#832
For golang#1788

Change-Id: Ic07e19f2f83cc4b05b3be750de4be7bcdb6e6656
gopherbot pushed a commit that referenced this issue Jul 21, 2022
@hyangah
test/integration/goTest: fix populateModulePathCache
47f6dfa 
And reenable affected tests.

The tests were broken due to a bug in composing the file Uris for
files in a directory from the directory Uri. path.join uses the
platform specific separator (\ on windows). To ensure the correct
encoding, convert the directory Uri to its fsPath, construct the
file path of the file, and convert the file path to Uri.

For #832
For #1788

Change-Id: I3dfc44e04f1683b1b862b339b7257b432c3f2241
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/418545
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@hyangah
Copy link
Contributor Author

hyangah commented Jul 21, 2022

FIxed and reenabled all tests on windows. Closing
Screen Shot 2022-07-21 at 5 30 51 PM
.

@hyangah hyangah closed this as completed Jul 21, 2022
gopherbot pushed a commit that referenced this issue Jul 22, 2022
@hyangah
src/goTest/resolve: fix nested packageDisplayMode handling on win32
d2afd7d 
To use path module, use Uri.fsPath, not Uri.path.

For #832
For #1788

Change-Id: Ic07e19f2f83cc4b05b3be750de4be7bcdb6e6656
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/418547
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@golang golang locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
FrozenDueToAge
Projects
None yet
Milestone
vscode-go/backlog
Development

No branches or pull requests
2 participants
@hyangah @gopherbot